Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DCL to v1.51.0 #8876

Merged
merged 24 commits into from
Sep 15, 2023
Merged

Conversation

NickElliot
Copy link
Contributor

@NickElliot NickElliot commented Sep 6, 2023

Release Note Template for Downstream PRs (will be copied)

containeraws: added support for `auto_repair` in `container_aws_node_pool`
containerazure: added support for `auto_repair` in `container_azure_node_pool`
networkconnectivity: added support for `linked_vpc_network` in `network_connectivity_spoke`
eventarc: field `event_data_content_type` in `eventarc_trigger` now marked as computed

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 220 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 9 files changed, 220 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 221 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 10 files changed, 221 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_aws_node_pool (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_aws_node_pool" "primary" {
  management {
    auto_repair = # value needed
  }
}

Resource: google_container_azure_node_pool (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_azure_node_pool" "primary" {
  management {
    auto_repair = # value needed
  }
}

Resource: google_network_connectivity_spoke (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_spoke" "primary" {
  linked_vpc_network {
    exclude_export_ranges = # value needed
    uri                   = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3014
Passed tests 2711
Skipped tests: 296
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccContainerAwsNodePool_BasicEnumHandWritten[Debug log]
TestAccContainerAwsNodePool_BasicHandWritten[Debug log]
TestAccContainerAwsNodePool_BetaBasicEnumHandWritten[Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 221 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 10 files changed, 221 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_aws_node_pool (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_aws_node_pool" "primary" {
  management {
    auto_repair = # value needed
  }
}

Resource: google_container_azure_node_pool (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_azure_node_pool" "primary" {
  management {
    auto_repair = # value needed
  }
}

Resource: google_network_connectivity_spoke (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_spoke" "primary" {
  linked_vpc_network {
    exclude_export_ranges = # value needed
    uri                   = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3020
Passed tests 2723
Skipped tests: 297
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 245 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 12 files changed, 245 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_spoke (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_spoke" "primary" {
  linked_vpc_network {
    exclude_export_ranges = # value needed
    uri                   = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3023
Passed tests 2723
Skipped tests: 297
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BasicHandWritten[Error message] [Debug log]
TestAccContainerAzureNodePool_BasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 245 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 12 files changed, 253 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_spoke (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_spoke" "primary" {
  linked_vpc_network {
    exclude_export_ranges = # value needed
    uri                   = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 381 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 13 files changed, 389 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3027
Passed tests 2724
Skipped tests: 297
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten|TestAccDataSourceGoogleServiceAccountJwt|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BasicHandWritten[Error message] [Debug log]
TestAccContainerAzureNodePool_BasicHandWritten[Error message] [Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 386 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 13 files changed, 400 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3028
Passed tests 2725
Skipped tests: 297
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BasicHandWritten[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccContainerAzureNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccContainerAzureNodePool_BasicHandWritten[Error message] [Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 386 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 13 files changed, 400 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3038
Passed tests 2736
Skipped tests: 297
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BasicHandWritten[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccContainerAzureNodePool_BasicHandWritten[Error message] [Debug log]
TestAccContainerAzureNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 421 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 15 files changed, 437 insertions(+), 12 deletions(-))

@hao-nan-li hao-nan-li self-requested a review September 14, 2023 20:09
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 424 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 15 files changed, 440 insertions(+), 12 deletions(-))

@NickElliot NickElliot marked this pull request as ready for review September 14, 2023 22:13
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 427 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 15 files changed, 443 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3046
Passed tests 2742
Skipped tests: 298
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BasicHandWritten[Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]
TestAccContainerAzureNodePool_BasicHandWritten[Debug log]
TestAccContainerAzureNodePool_BetaBasicHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicEnumHandWritten[Error message] [Debug log]
TestAccContainerAwsNodePool_BasicEnumHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…mputed to avoid complications with the flattener
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 435 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 15 files changed, 455 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3046
Passed tests 2745
Skipped tests: 298
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAzureNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccContainerAzureNodePool_BasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 443 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 15 files changed, 471 insertions(+), 32 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3055
Passed tests 2757
Skipped tests: 298
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@NickElliot NickElliot merged commit dd03c52 into GoogleCloudPlatform:main Sep 15, 2023
8 checks passed
@rileykarson
Copy link
Member

@NickElliot we made config.instance_type updatable too, I think, looking at the generated diffs! Someone pinged me about their change so I was looking at this. Can you write an upgrade entry for that, and work with the next release shepherd (@trodge I think) to include it in the release?

@NickElliot
Copy link
Contributor Author

NickElliot commented Sep 15, 2023

My bad! Do I need to just edit it into the original post here, or send it over to @trodge for manually updating the release notes?

containeraws: added update support for `config.instance_type` in  `container_aws_node_pool`

@melinath
Copy link
Member

you'll need to send it over to @trodge - release notes don't pick up changes after merge. You may also want to modify the eventarc line to focus more on customer impact of the switch to O+C. Something like:

eventarc: resolved permadiff on `google_eventarc_trigger.event_data_content_type` by defaulting to the value returned by the API if not set in the configuration.

RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
@rileykarson
Copy link
Member

You could theoretically edit the PR's changelog file in both repos to update the changelog generator (https://github.com/hashicorp/terraform-provider-google/blob/main/.changelog/8876.txt / https://github.com/hashicorp/terraform-provider-google-beta/blob/main/.changelog/8876.txt). But since we haven't done this before you'll still want to manually verify the changes worked (I'm also not sure if edits made after the cut date but before the cut is made would work- not an issue in this case, but possibly in others)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants