Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_chronicle_watchlist resource to chronicle #12648

Conversation

ankitgoyal0301
Copy link
Contributor

@ankitgoyal0301 ankitgoyal0301 commented Dec 24, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_chronicle_watchlist` (beta)

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 210 insertions(+))
google-beta provider: Diff ( 12 files changed, 1306 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_watchlist (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_watchlist" "primary" {
  name = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4383
Passed tests: 3949
Skipped tests: 429
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleWatchlist_chronicleWatchlistBasicExample
  • TestAccChronicleWatchlist_chronicleWatchlistBasicExample_update
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccChronicleWatchlist_chronicleWatchlistBasicExample [Error message] [Debug log]
TestAccChronicleWatchlist_chronicleWatchlistBasicExample_update [Error message] [Debug log]
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ankitgoyal0301
Copy link
Contributor Author

ankitgoyal0301 commented Dec 24, 2024

🟢 Tests passed during RECORDING mode: TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccChronicleWatchlist_chronicleWatchlistBasicExample [Error message] [Debug log] TestAccChronicleWatchlist_chronicleWatchlistBasicExample_update [Error message] [Debug log] TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log] TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Tests failed as the feature wasn't enabled on the relevant chronicle instance, enabled it now. The new execution should pass.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 210 insertions(+))
google-beta provider: Diff ( 12 files changed, 1305 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_watchlist (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_watchlist" "primary" {
  name = # value needed
}

@ankitgoyal0301
Copy link
Contributor Author

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 210 insertions(+)) google-beta provider: Diff ( 12 files changed, 1305 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_watchlist (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_watchlist" "primary" {
  name = # value needed
}

Regarding the missing test report, the name is of the form projects/{{project}}/locations/{{location}}/instances/{{instance}}/watchlists/{{watchlist}}, which is derived from project, instance and location and watchlist passed seperately.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4383
Passed tests: 3949
Skipped tests: 429
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleWatchlist_chronicleWatchlistBasicExample
  • TestAccChronicleWatchlist_chronicleWatchlistBasicExample_update
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleWatchlist_chronicleWatchlistBasicExample [Debug log]
TestAccChronicleWatchlist_chronicleWatchlistBasicExample_update [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions github-actions bot requested a review from zli82016 December 29, 2024 13:35
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 205 insertions(+))
google-beta provider: Diff ( 12 files changed, 1272 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 158 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4384
Passed tests: 3951
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleWatchlist_chronicleWatchlistBasicExample_update
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleWatchlist_chronicleWatchlistBasicExample_update [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 205 insertions(+))
google-beta provider: Diff ( 12 files changed, 1272 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 158 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4384
Passed tests: 3951
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants