Add google_chronicle_data_access_label resource to chronicle

[ankitgoyal0301]

`google_chronicle_data_access_label`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 154 insertions(+))
google-beta provider: Diff ( 12 files changed, 996 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_label (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_label" "primary" {
  name = # value needed
}

[ankitgoyal0301]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 154 insertions(+)) google-beta provider: Diff ( 12 files changed, 996 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_label (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_label" "primary" {
  name = # value needed
}

Regarding the missing test report, the name is of the form projects/{{project}}/locations/{{location}}/instances/{{instance}}/dataAccessLabels/{{data_access_label_id}}, which is derived from project, instance and location and data_access_label_id passed seperately.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 154 insertions(+))
google-beta provider: Diff ( 12 files changed, 996 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_label (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_label" "primary" {
  name = # value needed
}

[modular-magician]

Tests analytics

Total tests: 4383
Passed tests: 3948
Skipped tests: 429
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample
• TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample_update
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample [Debug log]
TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample_update [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 159 insertions(+))
google-beta provider: Diff ( 12 files changed, 996 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_label (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_label" "primary" {
  name = # value needed
}

[modular-magician]

Tests analytics

Total tests: 4383
Passed tests: 3950
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 164 insertions(+))
google-beta provider: Diff ( 12 files changed, 996 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_label (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_label" "primary" {
  name = # value needed
}

[modular-magician]

Tests analytics

Total tests: 4383
Passed tests: 3950
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[ankitgoyal0301]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 164 insertions(+)) google-beta provider: Diff ( 12 files changed, 996 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_label (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_label" "primary" {
  name = # value needed
}

Regarding the missing test report, the name is of the form projects/{{project}}/locations/{{location}}/instances/{{instance}}/dataAccessLabels/{{data_access_label_id}}, which is derived from project, instance and location and data_access_label_id passed seperately.

[ankitgoyal0301]

🟢 Tests passed during RECORDING mode: TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log] TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log] TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

The failing tests are not relevant to Chronicle.

[github-actions]

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 161 insertions(+))
google-beta provider: Diff ( 12 files changed, 965 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 79 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4384
Passed tests: 3950
Skipped tests: 429
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample_update
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample_update [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 151 insertions(+))
google-beta provider: Diff ( 7 files changed, 941 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 79 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• chronicle

🟢 All tests passed!

View the build log

[ronakgadia]

The maximum number of characters should be 63. Regex pattern is as per AIP: https://google.aip.dev/122#resource-id-segments

[ankitgoyal0301]

The current description is as per the comment in the proto, do we need to change that too? Sharing the link to that in our chat.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 151 insertions(+))
google-beta provider: Diff ( 7 files changed, 941 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 79 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample
• TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample [Debug log]
TestAccChronicleDataAccessLabel_chronicleDataaccesslabelBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.