refactor: resolve downstream gosimple warnings

[wyardley]

Release Note Template for Downstream PRs (will be copied)
Resolve some gofmt (missing -s) and gosimple findings in downstream provider.

See Write release notes for guidance.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 24 files changed, 49 insertions(+), 54 deletions(-))
google-beta provider: Diff ( 24 files changed, 49 insertions(+), 54 deletions(-))

[modular-magician]

Tests analytics

Total tests: 4354
Passed tests: 3944
Skipped tests: 407
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[wyardley]

I'm guessing the failing tests are unrelated, but let me know if you see otherwise in the logs, and I'll try running locally.

[ScottSuarez]

Yep ! unrelated