Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed mirrored_resources nested objects to set #12534

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jmgreger
Copy link
Contributor

@jmgreger jmgreger commented Dec 10, 2024

Fixes hashicorp/terraform-provider-google#20637

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: retyped `subnetworks` and `instances` of `google_compute_packet_mirroring` to sets

Copy link

google-cla bot commented Dec 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from BBBmau December 10, 2024 15:30
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 10, 2024
@jmgreger
Copy link
Contributor Author

My first commit I pushed with the wrong email, which is not tied to a CLA. I rebased to amend this but not sure if it needs a squash to handle that.

@modular-magician modular-magician added service/compute-packet-mirroring and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 38 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 1 file changed, 38 insertions(+), 26 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field mirrored_resources.instances changed from TypeList to TypeSet on google_compute_packet_mirroring - reference
  • Field mirrored_resources.subnetworks changed from TypeList to TypeSet on google_compute_packet_mirroring - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1072
Passed tests: 998
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputePacketMirroring_computePacketMirroringFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputePacketMirroring_computePacketMirroringFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Compute Packet Mirroring Subnet order causes state drift
2 participants