Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external catalog table options to google_bigquery_table beta #12528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented Dec 9, 2024

Add external catalog table options to google_bigquery_table beta.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigquery: added `external_catalog_table_options` fields to `google_bigquery_table` resource (beta)

@github-actions github-actions bot requested a review from zli82016 December 9, 2024 23:01
Copy link

github-actions bot commented Dec 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 72 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 3 files changed, 431 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_table (146 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_table" "primary" {
  external_catalog_table_options {
    connection_id = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 127
Passed tests: 116
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages
  • bigquery

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigQueryTable_externalCatalogTableOptions

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigQueryTable_externalCatalogTableOptions [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016
Copy link
Member

zli82016 commented Dec 9, 2024

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_table (146 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_table" "primary" {
  external_catalog_table_options {
    connection_id = # value needed
  }
}

Is it possible to add the missing test for connection_id?

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the missing test for connection_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants