Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cloud Run functions by adding support to the BuildConfig V2 API field #12512

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

akerekes
Copy link

@akerekes akerekes commented Dec 6, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 460 insertions(+))
google-beta provider: Diff ( 4 files changed, 563 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 151 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (51 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  build_config {
    base_image               = # value needed
    enable_automatic_updates = # value needed
    environment_variables {
      name  = # value needed
      value = # value needed
    }
    function_target = # value needed
    image_uri       = # value needed
    service_account = # value needed
    source_location = # value needed
    worker_pool     = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 44
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 460 insertions(+))
google-beta provider: Diff ( 4 files changed, 563 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 151 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (51 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  build_config {
    base_image               = # value needed
    enable_automatic_updates = # value needed
    environment_variables {
      name  = # value needed
      value = # value needed
    }
    function_target = # value needed
    image_uri       = # value needed
    service_account = # value needed
    source_location = # value needed
    worker_pool     = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 44
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 545 insertions(+))
google-beta provider: Diff ( 4 files changed, 545 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 151 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 165 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 44
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 546 insertions(+))
google-beta provider: Diff ( 4 files changed, 546 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 151 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 165 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 44
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants