Add condition and accessPolicyVersion to BQ dataset access #12475

obada-ab · 2024-12-03T14:50:24Z

Release Note Template for Downstream PRs (will be copied)

bigquery: added `condition` field to `google_bigquery_dataset_access` resource

bigquery: added `accessPolicyVersion=3` as a url parameter in `google_bigquery_dataset_access` resource

bigquery: added `condition` field to `google_bigquery_dataset` resource

bigquery: added `accessPolicyVersion=3` as a url parameter in `google_bigquery_dataset` resource

b/358332327

github-actions · 2024-12-03T14:51:04Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-12-03T15:01:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 233 insertions(+))
google-beta provider: Diff ( 4 files changed, 233 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 5 insertions(+))

modular-magician · 2024-12-03T15:05:11Z

Tests analytics

Total tests: 127
Passed tests: 3
Skipped tests: 10
Affected tests: 114

Click here to see the affected service packages

Action taken

Found 114 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-03T15:12:11Z

🟢 Tests passed during RECORDING mode:
TestAccBigQueryBigLakeManagedTable [Debug log]
TestAccBigQueryDataTable_canReorderParameters [Debug log]
TestAccBigQueryDataTable_expandArray [Debug log]
TestAccBigQueryDataTable_jsonEquivalency [Debug log]
TestAccBigQueryDataTable_sheet [Debug log]
TestAccBigQueryDatasetAccess_allAuthenticatedUsers [Debug log]
TestAccBigQueryDatasetAccess_allUsers [Debug log]
TestAccBigQueryDatasetAccess_authorizedDataset [Debug log]
TestAccBigQueryDatasetAccess_basic [Debug log]
TestAccBigQueryDatasetAccess_groupByEmailWithMixedCase [Debug log]
TestAccBigQueryDatasetAccess_iamMember [Debug log]
TestAccBigQueryDatasetAccess_predefinedRole [Debug log]
TestAccBigQueryDatasetAccess_userByEmailWithMixedCase [Debug log]
TestAccBigQueryDatasetAccess_view [Debug log]
TestAccBigQueryDataset_access [Debug log]
TestAccBigQueryDataset_basic [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetBasicExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalCatalogDatasetOptionsExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetResourceTags_update [Debug log]
TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample [Debug log]
TestAccBigQueryDataset_cmek [Debug log]
TestAccBigQueryDataset_datasetWithContents [Debug log]
TestAccBigQueryDataset_externalCatalogDatasetOptions_update [Debug log]
TestAccBigQueryDataset_regionalLocation [Debug log]
TestAccBigQueryDataset_storageBillModel [Debug log]
TestAccBigQueryExternalDataTable_CSV [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateToConnectionID [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_EuropeWest8 [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsCentral1LowerCase [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsEast1 [Debug log]
TestAccBigQueryExternalDataTable_deltaLake [Debug log]
TestAccBigQueryExternalDataTable_iceberg [Debug log]
TestAccBigQueryExternalDataTable_json [Debug log]
TestAccBigQueryExternalDataTable_objectTable [Debug log]
TestAccBigQueryExternalDataTable_parquet [Debug log]
TestAccBigQueryExternalDataTable_parquetFileSetSpecType [Debug log]
TestAccBigQueryExternalDataTable_parquetOptions [Debug log]
TestAccBigQueryExternalDataTable_queryAcceleration [Debug log]
TestAccBigQueryJob_bigqueryJobCopyExample [Debug log]
TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobExtractExample [Debug log]
TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadGeojsonExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadParquetExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobQueryExample [Debug log]
TestAccBigQueryJob_bigqueryJobQueryTableReferenceExample [Debug log]
TestAccBigQueryJob_withLocation [Debug log]
TestAccBigQueryRoutine_bigQueryRoutineRemoteFunction [Debug log]
TestAccBigQueryRoutine_bigQueryRoutineSparkJar_Update [Debug log]
TestAccBigQueryRoutine_bigQueryRoutine_Update [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineBasicExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineDataGovernanceTypeExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineJsonExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutinePysparkExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutinePysparkMainfileExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineSparkJarExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineTvfExample [Debug log]
TestAccBigQueryTableIamBindingGenerated [Debug log]
TestAccBigQueryTableIamMemberGenerated [Debug log]
TestAccBigQueryTableIamPolicyGenerated [Debug log]
TestAccBigQueryTable_AvroPartitioning [Debug log]
TestAccBigQueryTable_Basic [Debug log]
TestAccBigQueryTable_DropColumns [Debug log]
TestAccBigQueryTable_ForeignKey [Debug log]
TestAccBigQueryTable_HivePartitioning [Debug log]
TestAccBigQueryTable_HivePartitioningCustomSchema_update [Debug log]
TestAccBigQueryTable_HourlyTimePartitioning [Debug log]
TestAccBigQueryTable_Kms [Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic [Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update [Debug log]
TestAccBigQueryTable_MaterializedView_NonIncremental_basic [Debug log]
TestAccBigQueryTable_MonthlyTimePartitioning [Debug log]
TestAccBigQueryTable_OnlyDeletionProtectionUpdate [Debug log]
TestAccBigQueryTable_OnlyNestedFieldUpdate [Debug log]
TestAccBigQueryTable_PrimaryKey [Debug log]
TestAccBigQueryTable_RangePartitioning [Debug log]
TestAccBigQueryTable_ResourceTags [Debug log]
TestAccBigQueryTable_TableReplicationInfo_ConflictsWithView [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithReplicationInterval [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithoutReplicationInterval [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithoutPolicyTagsToWithPolicyTags [Debug log]
TestAccBigQueryTable_View [Debug log]
TestAccBigQueryTable_WithViewAndSchema [Debug log]
TestAccBigQueryTable_YearlyTimePartitioning [Debug log]
TestAccBigQueryTable_allowDestroy [Debug log]
TestAccBigQueryTable_emptySchema [Debug log]
TestAccBigQueryTable_schemaWithRequiredFieldAndView [Debug log]
TestAccBigQueryTable_updateTableConstraints [Debug log]
TestAccBigQueryTable_updateView [Debug log]
TestAccBigqueryDatasetIamBinding [Debug log]
TestAccBigqueryDatasetIamMember [Debug log]
TestAccBigqueryDatasetIamMember_afterDatasetCreation [Debug log]
TestAccBigqueryDatasetIamMember_iamMember [Debug log]
TestAccBigqueryDatasetIamMember_serviceAccount [Debug log]
TestAccBigqueryDatasetIamMember_withDeletedServiceAccount [Debug log]
TestAccBigqueryDatasetIamPolicy [Debug log]
TestAccDataSourceGoogleBigqueryDataset_basic [Debug log]
TestAccDataSourceGoogleBigqueryTables_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDatasetAccess_withCondition [Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample [Error message] [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseNameReference [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/templates/terraform/encoders/bigquery_dataset.go.tmpl

…agic-modules into dataset-acl-condition

modular-magician · 2024-12-04T12:11:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 282 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 282 insertions(+), 4 deletions(-))

modular-magician · 2024-12-04T12:14:47Z

Tests analytics

Total tests: 127
Passed tests: 5
Skipped tests: 10
Affected tests: 112

Click here to see the affected service packages

Action taken

Found 112 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-04T12:21:45Z

🟢 Tests passed during RECORDING mode:
TestAccBigQueryBigLakeManagedTable [Debug log]
TestAccBigQueryDataTable_canReorderParameters [Debug log]
TestAccBigQueryDataTable_expandArray [Debug log]
TestAccBigQueryDataTable_jsonEquivalency [Debug log]
TestAccBigQueryDataTable_sheet [Debug log]
TestAccBigQueryDatasetAccess_allAuthenticatedUsers [Debug log]
TestAccBigQueryDatasetAccess_allUsers [Debug log]
TestAccBigQueryDatasetAccess_authorizedDataset [Debug log]
TestAccBigQueryDatasetAccess_basic [Debug log]
TestAccBigQueryDatasetAccess_groupByEmailWithMixedCase [Debug log]
TestAccBigQueryDatasetAccess_iamMember [Debug log]
TestAccBigQueryDatasetAccess_predefinedRole [Debug log]
TestAccBigQueryDatasetAccess_userByEmailWithMixedCase [Debug log]
TestAccBigQueryDatasetAccess_view [Debug log]
TestAccBigQueryDataset_access [Debug log]
TestAccBigQueryDataset_basic [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetBasicExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalCatalogDatasetOptionsExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetResourceTags_update [Debug log]
TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample [Debug log]
TestAccBigQueryDataset_cmek [Debug log]
TestAccBigQueryDataset_datasetWithContents [Debug log]
TestAccBigQueryDataset_externalCatalogDatasetOptions_update [Debug log]
TestAccBigQueryDataset_regionalLocation [Debug log]
TestAccBigQueryDataset_storageBillModel [Debug log]
TestAccBigQueryExternalDataTable_CSV [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateToConnectionID [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_EuropeWest8 [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsCentral1LowerCase [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsEast1 [Debug log]
TestAccBigQueryExternalDataTable_deltaLake [Debug log]
TestAccBigQueryExternalDataTable_iceberg [Debug log]
TestAccBigQueryExternalDataTable_json [Debug log]
TestAccBigQueryExternalDataTable_objectTable [Debug log]
TestAccBigQueryExternalDataTable_parquet [Debug log]
TestAccBigQueryExternalDataTable_parquetFileSetSpecType [Debug log]
TestAccBigQueryExternalDataTable_parquetOptions [Debug log]
TestAccBigQueryExternalDataTable_queryAcceleration [Debug log]
TestAccBigQueryJob_bigqueryJobCopyExample [Debug log]
TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobExtractExample [Debug log]
TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadGeojsonExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadParquetExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobQueryExample [Debug log]
TestAccBigQueryJob_bigqueryJobQueryTableReferenceExample [Debug log]
TestAccBigQueryJob_withLocation [Debug log]
TestAccBigQueryRoutine_bigQueryRoutineRemoteFunction [Debug log]
TestAccBigQueryRoutine_bigQueryRoutineSparkJar_Update [Debug log]
TestAccBigQueryRoutine_bigQueryRoutine_Update [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineBasicExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineDataGovernanceTypeExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineJsonExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutinePysparkExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutinePysparkMainfileExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineSparkJarExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineTvfExample [Debug log]
TestAccBigQueryTableIamBindingGenerated [Debug log]
TestAccBigQueryTableIamMemberGenerated [Debug log]
TestAccBigQueryTableIamPolicyGenerated [Debug log]
TestAccBigQueryTable_AvroPartitioning [Debug log]
TestAccBigQueryTable_Basic [Debug log]
TestAccBigQueryTable_DropColumns [Debug log]
TestAccBigQueryTable_ForeignKey [Debug log]
TestAccBigQueryTable_HivePartitioning [Debug log]
TestAccBigQueryTable_HivePartitioningCustomSchema_update [Debug log]
TestAccBigQueryTable_HourlyTimePartitioning [Debug log]
TestAccBigQueryTable_Kms [Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic [Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update [Debug log]
TestAccBigQueryTable_MaterializedView_NonIncremental_basic [Debug log]
TestAccBigQueryTable_MonthlyTimePartitioning [Debug log]
TestAccBigQueryTable_OnlyDeletionProtectionUpdate [Debug log]
TestAccBigQueryTable_OnlyNestedFieldUpdate [Debug log]
TestAccBigQueryTable_PrimaryKey [Debug log]
TestAccBigQueryTable_RangePartitioning [Debug log]
TestAccBigQueryTable_ResourceTags [Debug log]
TestAccBigQueryTable_TableReplicationInfo_ConflictsWithView [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithReplicationInterval [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithoutReplicationInterval [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithoutPolicyTagsToWithPolicyTags [Debug log]
TestAccBigQueryTable_View [Debug log]
TestAccBigQueryTable_WithViewAndSchema [Debug log]
TestAccBigQueryTable_YearlyTimePartitioning [Debug log]
TestAccBigQueryTable_allowDestroy [Debug log]
TestAccBigQueryTable_emptySchema [Debug log]
TestAccBigQueryTable_schemaWithRequiredFieldAndView [Debug log]
TestAccBigQueryTable_updateTableConstraints [Debug log]
TestAccBigQueryTable_updateView [Debug log]
TestAccBigqueryDatasetIamBinding [Debug log]
TestAccBigqueryDatasetIamMember [Debug log]
TestAccBigqueryDatasetIamMember_afterDatasetCreation [Debug log]
TestAccBigqueryDatasetIamMember_iamMember [Debug log]
TestAccBigqueryDatasetIamMember_serviceAccount [Debug log]
TestAccBigqueryDatasetIamMember_withDeletedServiceAccount [Debug log]
TestAccBigqueryDatasetIamPolicy [Debug log]
TestAccDataSourceGoogleBigqueryDataset_basic [Debug log]
TestAccDataSourceGoogleBigqueryTables_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDatasetAccess_withCondition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…agic-modules into dataset-acl-condition

modular-magician · 2024-12-04T14:03:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 284 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 284 insertions(+), 4 deletions(-))

modular-magician · 2024-12-04T14:06:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 284 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 284 insertions(+), 4 deletions(-))

modular-magician · 2024-12-04T14:07:07Z

Tests analytics

Total tests: 127
Passed tests: 116
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-04T14:07:37Z

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDatasetAccess_withCondition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-04T14:10:54Z

Tests analytics

Total tests: 127
Passed tests: 116
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-04T14:11:24Z

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDatasetAccess_withCondition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-04T16:10:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 267 insertions(+))
google-beta provider: Diff ( 3 files changed, 267 insertions(+))

modular-magician · 2024-12-13T00:58:57Z

🟢 Tests passed during RECORDING mode:
TestAccBigQueryBigLakeManagedTable [Debug log]
TestAccBigQueryDataTable_canReorderParameters [Debug log]
TestAccBigQueryDataTable_expandArray [Debug log]
TestAccBigQueryDataTable_jsonEquivalency [Debug log]
TestAccBigQueryDataTable_sheet [Debug log]
TestAccBigQueryDatasetAccess_allAuthenticatedUsers [Debug log]
TestAccBigQueryDatasetAccess_allUsers [Debug log]
TestAccBigQueryDatasetAccess_authorizedDataset [Debug log]
TestAccBigQueryDatasetAccess_basic [Debug log]
TestAccBigQueryDatasetAccess_groupByEmailWithMixedCase [Debug log]
TestAccBigQueryDatasetAccess_iamMember [Debug log]
TestAccBigQueryDatasetAccess_predefinedRole [Debug log]
TestAccBigQueryDatasetAccess_userByEmailWithMixedCase [Debug log]
TestAccBigQueryDatasetAccess_view [Debug log]
TestAccBigQueryDatasetAccess_withCondition [Debug log]
TestAccBigQueryDataset_basic [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetBasicExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalCatalogDatasetOptionsExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample [Debug log]
TestAccBigQueryDataset_bigqueryDatasetResourceTags_update [Debug log]
TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample [Debug log]
TestAccBigQueryDataset_cmek [Debug log]
TestAccBigQueryDataset_datasetWithContents [Debug log]
TestAccBigQueryDataset_externalCatalogDatasetOptions_update [Debug log]
TestAccBigQueryDataset_regionalLocation [Debug log]
TestAccBigQueryDataset_storageBillModel [Debug log]
TestAccBigQueryExternalDataTable_CSV [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateToConnectionID [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_EuropeWest8 [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsCentral1LowerCase [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsEast1 [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseNameReference [Debug log]
TestAccBigQueryExternalDataTable_deltaLake [Debug log]
TestAccBigQueryExternalDataTable_iceberg [Debug log]
TestAccBigQueryExternalDataTable_json [Debug log]
TestAccBigQueryExternalDataTable_objectTable [Debug log]
TestAccBigQueryExternalDataTable_parquet [Debug log]
TestAccBigQueryExternalDataTable_parquetFileSetSpecType [Debug log]
TestAccBigQueryExternalDataTable_parquetOptions [Debug log]
TestAccBigQueryExternalDataTable_queryAcceleration [Debug log]
TestAccBigQueryJob_bigqueryJobCopyExample [Debug log]
TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobExtractExample [Debug log]
TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadGeojsonExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadParquetExample [Debug log]
TestAccBigQueryJob_bigqueryJobLoadTableReferenceExample [Debug log]
TestAccBigQueryJob_bigqueryJobQueryExample [Debug log]
TestAccBigQueryJob_bigqueryJobQueryTableReferenceExample [Debug log]
TestAccBigQueryJob_withLocation [Debug log]
TestAccBigQueryRoutine_bigQueryRoutineRemoteFunction [Debug log]
TestAccBigQueryRoutine_bigQueryRoutineSparkJar_Update [Debug log]
TestAccBigQueryRoutine_bigQueryRoutine_Update [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineBasicExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineDataGovernanceTypeExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineJsonExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutinePysparkExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutinePysparkMainfileExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineSparkJarExample [Debug log]
TestAccBigQueryRoutine_bigqueryRoutineTvfExample [Debug log]
TestAccBigQueryTableIamBindingGenerated [Debug log]
TestAccBigQueryTableIamMemberGenerated [Debug log]
TestAccBigQueryTableIamPolicyGenerated [Debug log]
TestAccBigQueryTable_AvroPartitioning [Debug log]
TestAccBigQueryTable_Basic [Debug log]
TestAccBigQueryTable_DropColumns [Debug log]
TestAccBigQueryTable_ForeignKey [Debug log]
TestAccBigQueryTable_HivePartitioning [Debug log]
TestAccBigQueryTable_HivePartitioningCustomSchema_update [Debug log]
TestAccBigQueryTable_HourlyTimePartitioning [Debug log]
TestAccBigQueryTable_Kms [Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic [Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update [Debug log]
TestAccBigQueryTable_MaterializedView_NonIncremental_basic [Debug log]
TestAccBigQueryTable_MonthlyTimePartitioning [Debug log]
TestAccBigQueryTable_OnlyDeletionProtectionUpdate [Debug log]
TestAccBigQueryTable_OnlyNestedFieldUpdate [Debug log]
TestAccBigQueryTable_PrimaryKey [Debug log]
TestAccBigQueryTable_RangePartitioning [Debug log]
TestAccBigQueryTable_ResourceTags [Debug log]
TestAccBigQueryTable_TableReplicationInfo_ConflictsWithView [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithReplicationInterval [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithoutReplicationInterval [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithoutPolicyTagsToWithPolicyTags [Debug log]
TestAccBigQueryTable_View [Debug log]
TestAccBigQueryTable_WithViewAndSchema [Debug log]
TestAccBigQueryTable_YearlyTimePartitioning [Debug log]
TestAccBigQueryTable_allowDestroy [Debug log]
TestAccBigQueryTable_emptySchema [Debug log]
TestAccBigQueryTable_schemaWithRequiredFieldAndView [Debug log]
TestAccBigQueryTable_updateTableConstraints [Debug log]
TestAccBigQueryTable_updateView [Debug log]
TestAccBigqueryDatasetIamBinding [Debug log]
TestAccBigqueryDatasetIamMember [Debug log]
TestAccBigqueryDatasetIamMember_afterDatasetCreation [Debug log]
TestAccBigqueryDatasetIamMember_iamMember [Debug log]
TestAccBigqueryDatasetIamMember_serviceAccount [Debug log]
TestAccBigqueryDatasetIamMember_withDeletedServiceAccount [Debug log]
TestAccBigqueryDatasetIamPolicy [Debug log]
TestAccDataSourceGoogleBigqueryDataset_basic [Debug log]
TestAccDataSourceGoogleBigqueryTables_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDataset_access [Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-13T12:44:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 430 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 7 files changed, 430 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 1 deletion(-))

modular-magician · 2024-12-13T12:46:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 430 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 7 files changed, 430 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 1 deletion(-))

modular-magician · 2024-12-13T12:47:56Z

Tests analytics

Total tests: 127
Passed tests: 115
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-13T12:48:27Z

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDataset_access [Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-13T12:50:03Z

Tests analytics

Total tests: 127
Passed tests: 115
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-13T12:50:33Z

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDataset_access [Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-13T14:18:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 1 deletion(-))

modular-magician · 2024-12-13T14:22:00Z

Tests analytics

Total tests: 127
Passed tests: 115
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-13T14:22:31Z

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDataset_access [Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAws [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-13T14:56:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 1 deletion(-))

modular-magician · 2024-12-13T15:01:08Z

Tests analytics

Total tests: 127
Passed tests: 115
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-13T15:02:27Z

🟢 Tests passed during RECORDING mode:
TestAccBigQueryDataset_access [Debug log]
TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAws [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

obada-ab · 2024-12-13T15:12:47Z

@zli82016 looks like the failure is caused by ?accessPolicyVersion=3 being added to resources' Name field, I'm not really sure why this is happening. Looking into it.

zli82016 · 2024-12-13T18:40:16Z

The failed terraform-google-conversion-build-and-unit-tests is due to the change of cai.AssetName, which can be seen in the diffs in terraform-google-conversion: Diff. The change of cai.AssetName is due to the change of self_link.

To avoid the change, a new field cai_base_url: 'projects/{{project}}/datasets/{{dataset_id}}' can be added to the file Dataset.yaml

modular-magician · 2024-12-13T19:42:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 1 deletion(-))

modular-magician · 2024-12-13T19:44:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 1 deletion(-))

modular-magician · 2024-12-13T19:46:03Z

Tests analytics

Total tests: 127
Passed tests: 117
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-13T19:49:01Z

Tests analytics

Total tests: 127
Passed tests: 117
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

zli82016 · 2024-12-13T19:55:49Z

mmv1/products/bigquery/Dataset.yaml

@@ -83,11 +86,6 @@ examples:
      dataset_id: 'example_dataset'
      account_name: 'bqowner'
    exclude_docs: true
-  - name: 'bigquery_dataset_external_reference_aws_test'


What is the reason to convert this test to the handwritten test?

zli82016 · 2024-12-13T19:56:02Z

/gcbrun

modular-magician · 2024-12-13T20:07:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 7 files changed, 471 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 1 deletion(-))

modular-magician · 2024-12-13T20:11:13Z

Tests analytics

Total tests: 127
Passed tests: 117
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

zli82016 · 2024-12-13T20:59:48Z

Sorry, it looks like adding cai_base_url doesn't fix the terraform-google-conversion-build-and-unit-tests.

Can you try another option, instead of adding cai_base_url?

Keep self_link unchanged by removing ?accessPolicyVersion=3 from the self_link.
self_link is used for GET and UPDATE url, which means that the GET url needs to be changed manually by adding pre_read custom code.
- Add the pre_read file to the folder https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/templates/terraform/pre_read
- Add the pre_read to the file Dataset.yaml
Add a update_url with ?accessPolicyVersion=3 to Dataset.yaml

obada-ab and others added 5 commits November 27, 2024 21:53

Add condition field to bigquery dataset access

0edec7b

Merge branch 'GoogleCloudPlatform:main' into dataset-acl-condition

3677133

Merge branch 'GoogleCloudPlatform:main' into dataset-acl-condition

1daccab

Fix bq dataset access with conditions

1f52ebe

Merge branch 'GoogleCloudPlatform:main' into dataset-acl-condition

2ef7a14

github-actions bot requested a review from zli82016 December 3, 2024 14:51

modular-magician added the service/bigquery label Dec 3, 2024

modular-magician requested a review from wj-chen December 3, 2024 15:01

zli82016 reviewed Dec 3, 2024

View reviewed changes

mmv1/templates/terraform/encoders/bigquery_dataset.go.tmpl Outdated Show resolved Hide resolved

obada-ab and others added 2 commits December 4, 2024 11:58

Merge branch 'dataset-acl-condition' of https://github.com/obada-ab/m…

0a7fcd3

…agic-modules into dataset-acl-condition

Merge branch 'GoogleCloudPlatform:main' into dataset-acl-condition

6903e71

github-actions bot requested a review from zli82016 December 4, 2024 12:01

obada-ab added 3 commits December 4, 2024 13:51

Add debug message for BQ dataset access entries

d91c15f

Merge branch 'dataset-acl-condition' of https://github.com/obada-ab/m…

3547901

…agic-modules into dataset-acl-condition

Remove unused bq dataset encoder

3c53b5e

Fix testAccCheckBigQueryDatasetAccess

1ac1ac4

obada-ab and others added 2 commits December 13, 2024 13:33

Merge branch 'GoogleCloudPlatform:main' into dataset-acl-condition

a7af1b3

Fix BQ dataset access test

82b6996

Move BQ external AWS dataset test to resource_bigquery_dataset_test

169be9d

Fix BQ dataset tests

3705c08

obada-ab and others added 2 commits December 13, 2024 20:30

Merge branch 'GoogleCloudPlatform:main' into dataset-acl-condition

bf98483

Add cai_base_url to BQ dataset

af61577

zli82016 reviewed Dec 13, 2024

View reviewed changes

Add condition and accessPolicyVersion to BQ dataset access #12475

Are you sure you want to change the base?

Add condition and accessPolicyVersion to BQ dataset access #12475

Conversation

obada-ab commented Dec 3, 2024 • edited Loading

github-actions bot commented Dec 3, 2024

modular-magician commented Dec 3, 2024

Diff report

modular-magician commented Dec 3, 2024

Tests analytics

Action taken

modular-magician commented Dec 3, 2024

modular-magician commented Dec 4, 2024

Diff report

modular-magician commented Dec 4, 2024

Tests analytics

Action taken

modular-magician commented Dec 4, 2024

modular-magician commented Dec 4, 2024

Diff report

modular-magician commented Dec 4, 2024

Diff report

modular-magician commented Dec 4, 2024

Tests analytics

Action taken

modular-magician commented Dec 4, 2024

modular-magician commented Dec 4, 2024

Tests analytics

Action taken

modular-magician commented Dec 4, 2024

modular-magician commented Dec 4, 2024

Diff report

modular-magician commented Dec 13, 2024

modular-magician commented Dec 13, 2024

Diff report

modular-magician commented Dec 13, 2024

Diff report

modular-magician commented Dec 13, 2024

Tests analytics

Action taken

modular-magician commented Dec 13, 2024

modular-magician commented Dec 13, 2024

Tests analytics

Action taken

modular-magician commented Dec 13, 2024

modular-magician commented Dec 13, 2024

Diff report

modular-magician commented Dec 13, 2024

Tests analytics

Action taken

modular-magician commented Dec 13, 2024

modular-magician commented Dec 13, 2024

Diff report

modular-magician commented Dec 13, 2024

Tests analytics

Action taken

modular-magician commented Dec 13, 2024

obada-ab commented Dec 13, 2024

zli82016 commented Dec 13, 2024

modular-magician commented Dec 13, 2024

Diff report

modular-magician commented Dec 13, 2024

Diff report

modular-magician commented Dec 13, 2024

Tests analytics

modular-magician commented Dec 13, 2024

Tests analytics

zli82016 Dec 13, 2024

Choose a reason for hiding this comment

zli82016 commented Dec 13, 2024

modular-magician commented Dec 13, 2024

Diff report

modular-magician commented Dec 13, 2024

Tests analytics

zli82016 commented Dec 13, 2024 • edited Loading

obada-ab commented Dec 3, 2024 •

edited

Loading

zli82016 commented Dec 13, 2024 •

edited

Loading