Add Repository Group resource with IAM #12424

JumiDeluxe · 2024-11-25T13:26:30Z

Release Note Template for Downstream PRs (will be copied)

Add new resources for Gemini Code Assist

`google_gemini_repository_group`

github-actions · 2024-11-25T13:27:11Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-11-25T13:37:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3099 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

JumiDeluxe · 2024-11-25T13:42:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 22 files changed, 3099 insertions(+), 5 deletions(-)) terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:
resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}
Resource: google_gemini_repository_group_iam_member (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:
resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Just a reminder that this resource will not support conditions at this moment

modular-magician · 2024-11-25T13:42:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3099 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T14:50:25Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T14:55:36Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T14:58:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3094 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T15:10:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3094 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T15:48:16Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMember [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T16:11:58Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T16:20:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3092 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T16:24:04Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T17:04:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3163 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T17:08:08Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMember [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:23:04Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccGeminiRepositoryGroupIamMember [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:33:42Z

Tests analytics

Total tests: 4320
Passed tests: 3908
Skipped tests: 407
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T18:16:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3226 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T18:18:59Z

Tests analytics

Total tests: 4322
Passed tests: 3908
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_noBootstrao

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T18:30:05Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiRepositoryGroupIamMember [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T18:59:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3226 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T19:18:01Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccGeminiRepositoryGroupIamMember [Debug log]
TestAccGeminiRepositoryGroup_noBootstrao [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T19:29:43Z

Tests analytics

Total tests: 4322
Passed tests: 3909
Skipped tests: 407
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_noBootstrao

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T19:32:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3226 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

mmv1/third_party/terraform/services/gemini/resource_gemini_repository_group_test.go.tmpl

modular-magician · 2024-11-25T20:11:39Z

Tests analytics

Total tests: 4322
Passed tests: 3907
Skipped tests: 407
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

TestAccFolderIamPolicy_basic

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_noBootstrao

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-26T14:55:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 407 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 2315 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-26T14:58:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 407 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 2315 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-26T15:09:39Z

Tests analytics

Total tests: 4322
Passed tests: 3912
Skipped tests: 407
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiRepositoryGroup_noBootstrap

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-26T16:04:55Z

🔴 Tests failed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]
TestAccGeminiRepositoryGroup_noBootstrap [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-26T16:07:13Z

Tests analytics

Total tests: 4322
Passed tests: 3912
Skipped tests: 407
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiRepositoryGroup_noBootstrap

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-26T16:19:14Z

Tests analytics

Total tests: 4322
Passed tests: 3912
Skipped tests: 407
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiRepositoryGroup_noBootstrap

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-26T16:23:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 407 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 2315 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-26T17:02:42Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroup_noBootstrap [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-26T17:16:19Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroup_noBootstrap [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-26T17:37:06Z

Tests analytics

Total tests: 4322
Passed tests: 3908
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

TestAccGeminiRepositoryGroup_noBootstrap

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-26T18:37:35Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccGeminiRepositoryGroup_noBootstrap [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-26T20:36:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 407 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 2321 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-26T21:49:13Z

Tests analytics

Total tests: 4322
Passed tests: 3906
Skipped tests: 407
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

slevenick · 2024-11-26T21:56:03Z

mmv1/products/gemini/RepositoryGroup.yaml

+name: RepositoryGroup
+description: The resource for managing Repository Group for Gemini Code Assist.
+min_version: 'beta'
+base_url: projects/{{project}}/locations/{{location}}/codeRepositoryIndexes/{{code_repository_index_id}}/repositoryGroups


Typically we would name this code_repository_index rather than code_repository_index_id. Not necessary, but I would suggest changing that here and everywhere in this file.

Yes, I've changed it to the code_repository_index_id to make it clear that it should hold the same value as in the CodeRepositoryIndex.yaml resource. I can change it back.

slevenick · 2024-11-26T21:56:38Z

mmv1/products/gemini/RepositoryGroup.yaml

+  error:
+    path: error
+    message: message
+  include_project: false


Why include_project: false? I'd guess we should include project here

It was generated like that and we didn't need to change the value. Same in the CodeRepositoryIndex.yaml resource. I can change this field's value in both resources if they are usually intended to be set to true.

Surprisingly, setting it to true generates providers with no new variables on left side of := errors in the Create, Update and Delete functions due to the project variable declaration

slevenick · 2024-11-26T21:58:00Z

mmv1/products/gemini/RepositoryGroup.yaml

+  - name: location
+    type: String
+    description: The location of the Code Repository Index, for example `us-central1`.
+    min_version: 'beta'


You shouldn't need min_version on all of these individual fields. It's implied because the resource itself is beta-only

slevenick · 2024-11-26T22:00:53Z

mmv1/third_party/terraform/transport/error_retry_predicates.go

+		return false, ""
+	}
+
+	if gerr.Code == 409 && strings.Contains(gerr.Body, "parent resource not in ready state") {


FYI when we start depending on error message contents it makes it extremely difficult to change the error messages on the API side in the future. That's the state of the world today so it's not unreasonable to add this, but it does have downsides

slevenick · 2024-11-26T22:01:51Z

mmv1/third_party/terraform/services/gemini/iam_gemini_repository_group_test.go.tmpl

+// To run tests locally please replace the `oauth_token_secret_version` with your secret manager version.
+// More details: https://cloud.google.com/developer-connect/docs/connect-github-repo#before_you_begin
+
+func TestAccGeminiRepositoryGroupIamBinding(t *testing.T) {


Were you unable to get the IAM tests to generate? We shouldn't need handwritten test files like this if the IAM generation works as expected

modular-magician · 2024-11-26T22:48:17Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-27T02:30:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 409 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 2444 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-27T03:42:43Z

Tests analytics

Total tests: 4328
Passed tests: 3909
Skipped tests: 407
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-27T04:43:38Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-27T11:23:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 409 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 2444 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-27T12:35:25Z

Tests analytics

Total tests: 4328
Passed tests: 3909
Skipped tests: 407
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-27T13:39:28Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

JumiDeluxe marked this pull request as draft November 25, 2024 13:26

github-actions bot requested a review from slevenick November 25, 2024 13:27

JumiDeluxe marked this pull request as ready for review November 25, 2024 16:22

JumiDeluxe force-pushed the repository-group branch from 21a0e1f to 8cdc5b6 Compare November 25, 2024 18:48

JumiDeluxe force-pushed the repository-group branch from 8cdc5b6 to 51740e8 Compare November 25, 2024 19:21

slevenick reviewed Nov 25, 2024

View reviewed changes

mmv1/third_party/terraform/services/gemini/resource_gemini_repository_group_test.go.tmpl Outdated Show resolved Hide resolved

mmv1/third_party/terraform/services/gemini/resource_gemini_repository_group_test.go.tmpl Show resolved Hide resolved

JumiDeluxe force-pushed the repository-group branch from 34570be to 4ee23d2 Compare November 26, 2024 14:45

devid-shyliuk approved these changes Nov 26, 2024

View reviewed changes

Retry on CodeRepositoryIndex unready

86c8166

JumiDeluxe force-pushed the repository-group branch from 4ee23d2 to 86c8166 Compare November 26, 2024 16:12

Add a comment about running RepositoryGroup tests locally

601cc8b

slevenick reviewed Nov 26, 2024

View reviewed changes

github-actions bot requested a review from slevenick November 27, 2024 02:19

JumiDeluxe force-pushed the repository-group branch from f5660da to c9fae0b Compare November 27, 2024 11:12

Remove not needed beta tags, RepositoryGroup IAM test template

91bb8d1

JumiDeluxe force-pushed the repository-group branch from c9fae0b to 91bb8d1 Compare November 27, 2024 14:31

Add Repository Group resource with IAM #12424

Are you sure you want to change the base?

Add Repository Group resource with IAM #12424

Conversation

JumiDeluxe commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Missing test report

JumiDeluxe commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 26, 2024

Diff report

Missing test report

modular-magician commented Nov 26, 2024

Diff report

Missing test report

modular-magician commented Nov 26, 2024

Tests analytics

Action taken

modular-magician commented Nov 26, 2024

modular-magician commented Nov 26, 2024

Tests analytics

Action taken

modular-magician commented Nov 26, 2024

Tests analytics