Make allowedPersistenceRegions optional in messageStoragePolicy for google_pubsub_topic. #12403
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
modular-magician
added
the
awaiting-approval
…oogle_pubsub_topic fix test function name
shunsuke-tsumori
force-pushed
the
fix/google_pubsub_topic-optional-message_storage_policy
branch
from
05cc615
to
2354d60
Compare
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| @@ -126,7 +126,7 @@ properties: | |||
| of GCP altogether) will be routed for storage in one of the | |||
| allowed regions. An empty list means that no regions are allowed, | |||
| and is not a valid configuration. | |||
| required: true | |||
There was a problem hiding this comment.
I'm not seeing how this solves hashicorp/terraform-provider-google#20431
The original debug log shows no required validation message for this field
|
|
||
| updatedConfig := ` | ||
| resource "google_pubsub_topic" "usage-metrics" { | ||
| name = "topic-name" |
There was a problem hiding this comment.
this isn't actually testing the change on allowedPersistenceRegions, this is testing removing message_storage_policy
closes hashicorp/terraform-provider-google#20431
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.