Adding ipv6 support for bgp router peer, router interface and router. #10204

Gorlami96 · 2024-03-15T09:18:26Z

Adding ipv6 support for bgp router peer, router interface and router. Related to b/309454013

*Release Note Template for Downstream PRs

compute: Adding support for ipv6 enhancements in google_compute_router, google_compute_router_interface and google_compute_router_peer

github-actions · 2024-03-20T05:40:03Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

ScottSuarez · 2024-03-21T00:55:35Z

/gcbrun

ScottSuarez · 2024-03-22T01:14:13Z

Hey @Gorlami96, sorry for the delay here!

Could you pull the latest changes in from main when you get a chance.

modular-magician · 2024-03-22T01:26:30Z

Tests analytics

Total tests: 897
Passed tests: 807
Skipped tests: 72
Affected tests: 18

Click here to see the affected service packages

compute

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCompouteRouter_addIdentifierRangeBgp|TestAccComputeRouterBgpPeer_routerPeerRouterAppliance|TestAccComputeRouterInterface_withIPVersionV4|TestAccComputeRouterInterface_withIPVersionV6|TestAccComputeRouterPeer_AddMd5AuthenticationKey|TestAccComputeRouterPeer_EnableDisableIpv6|TestAccComputeRouterPeer_Ipv4Basic|TestAccComputeRouterPeer_Ipv6Basic|TestAccComputeRouterPeer_UpdateIpv4|TestAccComputeRouterPeer_UpdateIpv6Address|TestAccComputeRouterPeer_UpdateMd5AuthenticationKey|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_routerApplianceInstance|TestAccComputeRouter_updateIdentifierRangeBgp|TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

modular-magician · 2024-03-22T01:32:57Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCompouteRouter_addIdentifierRangeBgp[Debug log]
TestAccComputeRouterPeer_Ipv4Basic[Debug log]
TestAccComputeRouterPeer_UpdateIpv4[Debug log]
TestAccComputeRouter_updateIdentifierRangeBgp[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance[Error message] [Debug log]
TestAccComputeRouterInterface_withIPVersionV4[Error message] [Debug log]
TestAccComputeRouterInterface_withIPVersionV6[Error message] [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey[Error message] [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6[Error message] [Debug log]
TestAccComputeRouterPeer_Ipv6Basic[Error message] [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address[Error message] [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_routerApplianceInstance[Error message] [Debug log]
TestAccDataSourceComputeRouterStatus[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

ScottSuarez · 2024-03-22T15:51:02Z

Looks like we have some failing tests.

  | Error: Error creating RouterBgpPeer: googleapi: Error 400: Invalid value for field 'resource.bgpPeers[0].peerIpAddress': '10.0.0.3'. The IP version of Peer IP must not be disabled., invalid
  | 
  |   with google_compute_router_peer.peer,
  |   on terraform_plugin_test.tf line 97, in resource "google_compute_router_peer" "peer":
  |   97: resource "google_compute_router_peer" "peer" {
  | 
   test_terraform_path=/bin/terraform
2024-03-22T01:27:57.723Z [DEBUG] sdk.helper_resource: Stopping providers: test_terraform_path=/bin/terraform test_working_directory=/tmp/plugintest1545503077 test_name=TestAccComputeRouterBgpPeer_routerPeerRouterAppliance test_step_number=1
2024-03-22T01:27:57.724Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccComputeRouterBgpPeer_routerPeerRouterAppliance test_step_number=1 test_terraform_path=/bin/terraform
  error=
  | Error running apply: exit status 1
  | 
  | Error: Error creating RouterBgpPeer: googleapi: Error 400: Invalid value for field 'resource.bgpPeers[0].peerIpAddress': '10.0.0.3'. The IP version of Peer IP must not be disabled., invalid
  | 
  |   with google_compute_router_peer.peer,
  |   on terraform_plugin_test.tf line 97, in resource "google_compute_router_peer" "peer":
  |   97: resource "google_compute_router_peer" "peer" {

Let me know if you need help investigating. If you cmd+F in the logs for unexpected error it will bring you to the error the application threw.

Gorlami96 · 2024-03-25T14:55:41Z

Ack. Fixing tests on this.

ScottSuarez · 2024-04-01T22:02:11Z

/gcbrun

modular-magician · 2024-04-01T22:14:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+))
google-beta provider: Diff ( 7 files changed, 608 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-04-01T22:34:05Z

Tests analytics

Total tests: 897
Passed tests: 810
Skipped tests: 72
Affected tests: 15

Click here to see the affected service packages

compute

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRouterBgpPeer_routerPeerRouterAppliance|TestAccComputeRouterInterface_withIPVersionV4|TestAccComputeRouterInterface_withIPVersionV6|TestAccComputeRouterPeer_AddMd5AuthenticationKey|TestAccComputeRouterPeer_EnableDisableIpv6|TestAccComputeRouterPeer_Ipv6Basic|TestAccComputeRouterPeer_UpdateIpv6Address|TestAccComputeRouterPeer_UpdateMd5AuthenticationKey|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_routerApplianceInstance|TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

modular-magician · 2024-04-01T22:43:17Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputeRouterInterface_withIPVersionV4[Debug log]
TestAccComputeRouterInterface_withIPVersionV6[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance[Error message] [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey[Error message] [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6[Error message] [Debug log]
TestAccComputeRouterPeer_Ipv6Basic[Error message] [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address[Error message] [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_routerApplianceInstance[Error message] [Debug log]
TestAccDataSourceComputeRouterStatus[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Gorlami96 · 2024-04-03T12:55:49Z

/gcbrun

ScottSuarez · 2024-04-03T19:02:51Z

/gcbrun

shuyama1 · 2024-04-03T19:54:13Z

@Gorlami96 Sorry, there's an issue in our CI. Would you mind rebasing your PR to catch the latest fix? Thank you!

ScottSuarez · 2024-04-04T18:21:14Z

/gcbrun

modular-magician · 2024-04-04T18:33:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 44 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 7 files changed, 646 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-04-04T18:53:47Z

Tests analytics

Total tests: 898
Passed tests: 824
Skipped tests: 72
Affected tests: 2

Click here to see the affected service packages

compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouterPeer_AddMd5AuthenticationKey|TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

Get to know how VCR tests work

modular-magician · 2024-04-04T18:59:23Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRouterPeer_AddMd5AuthenticationKey[Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

ScottSuarez · 2024-04-04T20:10:11Z

Looks like there a is a merge conflict

mmv1/third_party/terraform/services/compute/resource_compute_router_bgp_peer_test.go

)

Gorlami96 · 2024-04-05T09:48:02Z

Apologies but this branch has some issues. I have opened another PR #10375 with the same content. Closing this PR

Shivang Dixit added 2 commits March 15, 2024 09:14

Adding ipv6 support for bgp router peer, router interface and router.

a241521

Added tests for interface and router new fields

026256b

Gorlami96 marked this pull request as ready for review March 20, 2024 05:39

github-actions bot requested a review from ScottSuarez March 20, 2024 05:40

Shivang Dixit and others added 2 commits April 1, 2024 09:19

Fixing build issue

5dc0990

Merge branch 'GoogleCloudPlatform:main' into bgp-ipv6

4579ab5

fixing tests

e463d66

Gorlami96 and others added 2 commits April 4, 2024 11:26

Merge branch 'GoogleCloudPlatform:main' into bgp-ipv6

0bf8d9b

Enabling computed flag for enable_ipv4 field in router peer

12f2428

pcostell and others added 5 commits April 5, 2024 08:27

test: Fix missing database for datastore_index test. (GoogleCloudPlat…

c1a0366

…form#10316)

Added "endpointTypes" support to compute router nat resource (GoogleC…

e3a5857

…loudPlatform#10338)

make vcr_merge wait until all downstream pushes finish (GoogleCloudPl…

e5f98ea

…atform#10369)

Don't request reviewers if there are none to request. (GoogleCloudPla…

c493aef

…tform#10371)

Allow in-place column drop for bigquery table (GoogleCloudPlatform#10170

323ac2c

)

Gorlami96 closed this Apr 5, 2024

Gorlami96 deleted the bgp-ipv6 branch April 5, 2024 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding ipv6 support for bgp router peer, router interface and router. #10204

Adding ipv6 support for bgp router peer, router interface and router. #10204

Gorlami96 commented Mar 15, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024

ScottSuarez commented Mar 21, 2024

ScottSuarez commented Mar 22, 2024 •

edited

Loading

modular-magician commented Mar 22, 2024

modular-magician commented Mar 22, 2024

ScottSuarez commented Mar 22, 2024

Gorlami96 commented Mar 25, 2024

ScottSuarez commented Apr 1, 2024

modular-magician commented Apr 1, 2024

modular-magician commented Apr 1, 2024

modular-magician commented Apr 1, 2024

Gorlami96 commented Apr 3, 2024

ScottSuarez commented Apr 3, 2024

shuyama1 commented Apr 3, 2024

ScottSuarez commented Apr 4, 2024

modular-magician commented Apr 4, 2024

modular-magician commented Apr 4, 2024

modular-magician commented Apr 4, 2024

ScottSuarez commented Apr 4, 2024

Gorlami96 commented Apr 5, 2024 •

edited

Loading

Adding ipv6 support for bgp router peer, router interface and router. #10204

Adding ipv6 support for bgp router peer, router interface and router. #10204

Conversation

Gorlami96 commented Mar 15, 2024 • edited Loading

github-actions bot commented Mar 20, 2024

ScottSuarez commented Mar 21, 2024

ScottSuarez commented Mar 22, 2024 • edited Loading

modular-magician commented Mar 22, 2024

Tests analytics

Action taken

modular-magician commented Mar 22, 2024

ScottSuarez commented Mar 22, 2024

Gorlami96 commented Mar 25, 2024

ScottSuarez commented Apr 1, 2024

modular-magician commented Apr 1, 2024

Diff report

modular-magician commented Apr 1, 2024

Tests analytics

Action taken

modular-magician commented Apr 1, 2024

Gorlami96 commented Apr 3, 2024

ScottSuarez commented Apr 3, 2024

shuyama1 commented Apr 3, 2024

ScottSuarez commented Apr 4, 2024

modular-magician commented Apr 4, 2024

Diff report

modular-magician commented Apr 4, 2024

Tests analytics

Action taken

modular-magician commented Apr 4, 2024

ScottSuarez commented Apr 4, 2024

Gorlami96 commented Apr 5, 2024 • edited Loading

Gorlami96 commented Mar 15, 2024 •

edited

Loading

ScottSuarez commented Mar 22, 2024 •

edited

Loading

Gorlami96 commented Apr 5, 2024 •

edited

Loading