Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs for Smart Scheduling feature in BackupPlan for Backup for GKE #10183

Closed
wants to merge 1 commit into from

Conversation

cmfeng
Copy link
Contributor

@cmfeng cmfeng commented Mar 13, 2024

Add APIs for Smart Scheduling feature in BackupPlan for Backup for GKE

Design doc: go/gkebackup-smart-schedule-design

Release Note Template for Downstream PRs (will be copied)


@cmfeng cmfeng closed this Mar 13, 2024
@cmfeng cmfeng reopened this Mar 13, 2024
@cmfeng cmfeng force-pushed the schedule branch 2 times, most recently from 34a2789 to 90d783d Compare March 14, 2024 20:34
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 804 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 804 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 249 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_backup_plan (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_backup_plan" "primary" {
  backup_schedule {
    rpo_config {
      exclusion_windows {
        daily = # value needed
        days_of_week {
          days_of_week = # value needed
        }
        duration {
          nanos   = # value needed
          seconds = # value needed
        }
        single_occurrence_date {
          day   = # value needed
          month = # value needed
          year  = # value needed
        }
        start_time {
          hours   = # value needed
          minutes = # value needed
          nanos   = # value needed
          seconds = # value needed
        }
      }
      target_rpo_minutes = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gkebackup

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@cmfeng cmfeng force-pushed the schedule branch 3 times, most recently from b44d1cc to 587df08 Compare March 20, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants