-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hashicorp/terraform-plugin-framework, terraform-plugin-mux, terraform-plugin-sdk/v2 to navigate breaking change in provider-defined functions #10109
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
ad2836c
to
d17f21d
Compare
Rebased branch to pull in latest changes from the feature branch, plus resolved merge conflicts in go.mod and go.sum |
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 144 insertions(+), 195 deletions(-)) |
c96e0cf
to
f53204e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 14 files changed, 196 insertions(+), 255 deletions(-)) |
…1.6.0` This diff is the result of running: * go get github.com/hashicorp/[email protected] * go get github.com/hashicorp/[email protected] * go get github.com/hashicorp/terraform-plugin-sdk/[email protected] * go mod tidy
…stics. Remove use of warnings as a result, opt for debug log instead.
* go get hashicorp/terraform-plugin-framework v1.6.1 * go mod tidy
3dd88b4
to
eaef718
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
I've triggered acceptance tests to run in TeamCity on the diff report branch for GA : https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_FEATUREBRANCHPROVIDERFUNCTIONS_MM_GA_GOOGLE_PACKAGE_FUNCTIONS/118767?mode=builds&buildTab=overview&hideTestsFromDependencies=false&hideProblemsFromDependencies=false Edit - all passed 😁 |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaseAndroidApp_update|TestAccNetappkmsconfig_kmsConfigCreateExample_Update|TestAccNotebooksInstance_notebookInstanceFullExample |
|
@BBBmau friendly reminder 😁 Also, here's a screenshot from when I ran an internal test locally to see the debug log after removing use of tflog. The log replaces the previous use of warnings (see PR description). |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
@SarahFrench Thank you for the ping! I completely lost track of this. Reviewing right now. |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUnenforcedExample|TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUpdate|TestAccFirestoreIndex_firestoreIndexBasicExample|TestAccFirestoreIndex_firestoreIndexDatastoreModeExample|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfig_updateHostDetails |
Thanks! I'll wait for checks to finish and then merge |
|
This failure isn't related to the PR - merging |
f0f29d2
into
FEATURE-BRANCH-provider-functions
This PR upgrades the provider functions to use Errors instead of Diagnostics - this is a breaking change introduced in plugin-framework 1.6.0 . By addressing it now I want to avoid navigating those changes after a function is released.
Impact of the change is that provider-defined functions cannot issue warnings anymore, only errors. I've replaced use of warnings with debug logs.
I wanted the debug log to include information about which function was making the log. This required some refactoring about where we set the function's name, to make it accessible in the Run logic of the individual functions.
Release Note Template for Downstream PRs (will be copied)