fix documentation and pr comments featureonlinestore

GoogleCloudPlatform · Dec 20, 2023 · b9c3210 · b9c3210
1 parent 4cb830c
commit b9c3210
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 21 deletions.
diff --git a/mmv1/products/vertexai/FeatureOnlineStore.yaml b/mmv1/products/vertexai/FeatureOnlineStore.yaml
@@ -86,6 +86,7 @@ properties:
     description: The resource name of the Feature Online Store. This value may be up to 60 characters, and
       valid characters are [a-z0-9_]. The first character cannot be a number.
     immutable: true
+    required: true
     url_param_only: true
     pattern: projects/{{project}}/locations/{{region}}/featureOnlineStores/{{name}}
     custom_flatten: templates/terraform/custom_flatten/name_from_self_link.erb
@@ -112,6 +113,9 @@ properties:
   - !ruby/object:Api::Type::NestedObject
     name: bigtable
     description: Settings for Cloud Bigtable instance that will be created to serve featureValues for all FeatureViews under this FeatureOnlineStore.
+    exactly_one_of:
+      - bigtable
+      - optimized
     properties:
       - !ruby/object:Api::Type::NestedObject
         name: autoScaling
@@ -136,7 +140,7 @@ properties:
   - !ruby/object:Api::Type::NestedObject
     name: optimized
     description:
-      Contains settings for the Optimized store that will be created to serve featureValues for all FeatureViews under this FeatureOnlineStore
+      Settings for the Optimized store that will be created to serve featureValues for all FeatureViews under this FeatureOnlineStore
     conflicts:
       - embeddingManagement
     exactly_one_of:
@@ -159,12 +163,12 @@ properties:
       - !ruby/object:Api::Type::String
         name: publicEndpointDomainName
         description: |
-          populated with the domain name to use for this FeatureOnlineStore
+          Domain name to use for this FeatureOnlineStore
         output: true
       - !ruby/object:Api::Type::String
         name: serviceAttachment
         description: |
-          name of the service attachment resource. Populated if private service connect is enabled and after FeatureViewSync is created.
+          Name of the service attachment resource. Applicable only if private service connect is enabled and after FeatureViewSync is created.
         output: true
       - !ruby/object:Api::Type::NestedObject
         name: privateServiceConnectConfig

diff --git a/mmv1/templates/terraform/examples/vertex_ai_featureonlinestore_with_bigtable.tf.erb b/mmv1/templates/terraform/examples/vertex_ai_featureonlinestore_with_bigtable.tf.erb
diff --git a/mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_online_store_test.go b/mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_online_store_test.go
@@ -57,7 +57,6 @@ resource google_vertex_ai_feature_online_store "feature_online_store" {
             cpu_utilization_target = 60
         }
     }
-  }
   force_destroy = true
 }
 `, context)
@@ -79,7 +78,6 @@ resource google_vertex_ai_feature_online_store "feature_online_store" {
             max_node_count = 3
         }
     }
-  }
   force_destroy = true
 }
 `, context)