Update documentation for google_bigquery_table.time_partitioning.expi…

…ration_ms (#8827)
GoogleCloudPlatform · Sep 15, 2023 · 7d9dc66 · 7d9dc66
1 parent 6696d29
commit 7d9dc66
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/mmv1/products/bigquery/Table.yaml b/mmv1/products/bigquery/Table.yaml
@@ -175,7 +175,10 @@ properties:
         name: 'expirationMs'
         description: |
           Number of milliseconds for which to keep the storage for a
-          partition.
+          partition. If unspecified when the table is created in a dataset
+          that has `defaultPartitionExpirationMs`, it will inherit
+          the value of `defaultPartitionExpirationMs` from the dataset.
+          To specify a unlimited expiration, set the value to 0.
       - !ruby/object:Api::Type::String
         name: 'field'
         description: |

diff --git a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go
@@ -865,8 +865,11 @@ func ResourceBigQueryTable() *schema.Resource {
 				Description: `If specified, configures time-based partitioning for this table.`,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
-						// ExpirationMs: [Optional] Number of milliseconds for which to keep the
-						// storage for a partition.
+						// ExpirationMs: [Optional] Number of milliseconds for which to keep the storage for a
+						// partition. If unspecified when the table is created in a dataset that has
+						// `defaultPartitionExpirationMs`, it will inherit the value of
+						// `defaultPartitionExpirationMs` from the dataset.
+						// To specify a unlimited expiration, set the value to 0.
 						"expiration_ms": {
 							Type:        schema.TypeInt,
 							Optional:    true,

diff --git a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go
@@ -1441,6 +1441,7 @@ resource "google_bigquery_table" "test" {
     type                     = "%s"
     field                    = "ts"
     require_partition_filter = true
+    expiration_ms            = 1000
   }
   clustering = ["some_int", "some_string"]
   schema     = <<EOH