Remove minimal example & pattern field

GoogleCloudPlatform · Feb 14, 2024 · 0e22278 · 0e22278
1 parent 5b8cba4
commit 0e22278
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 57 deletions.
diff --git a/mmv1/products/firebaseappcheck/DeviceCheckConfig.yaml b/mmv1/products/firebaseappcheck/DeviceCheckConfig.yaml
@@ -35,22 +35,6 @@ import_format:
     "{{app_id}}",
   ]
 examples:
-  - !ruby/object:Provider::Terraform::Examples
-    name: "firebase_app_check_device_check_config_minimal"
-    # Need the time_sleep resource
-    pull_external: true
-    primary_resource_id: "default"
-    vars:
-      bundle_id: "bundle.id.devicecheck"
-      key_id: "Key ID"
-      private_key_path: "path/to/private-key.p8"
-      team_id: "9987654321"
-    test_vars_overrides:
-      # Don't add random suffix
-      private_key_path: '"test-fixtures/private-key.p8"'
-      team_id: '"9987654321"'
-    test_env_vars:
-      project_id: :PROJECT_NAME
   - !ruby/object:Provider::Terraform::Examples
     name: "firebase_app_check_device_check_config_full"
     # Need the time_sleep resource
@@ -84,7 +68,6 @@ properties:
     description: |
       The relative resource name of the DeviceCheck configuration object
     output: true
-    pattern: projects/{{project}}/apps/{{app_id}}/deviceCheckConfig
   - !ruby/object:Api::Type::String
     name: tokenTtl
     description: |

diff --git a/mmv1/templates/terraform/examples/firebase_app_check_device_check_config_minimal.tf.erb b/mmv1/templates/terraform/examples/firebase_app_check_device_check_config_minimal.tf.erb
diff --git a/...rraform/services/firebaseappcheck/resource_firebase_app_check_device_check_config_test.go b/...rraform/services/firebaseappcheck/resource_firebase_app_check_device_check_config_test.go
@@ -16,7 +16,7 @@ func TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigU
 		"project_id":       envvar.GetTestProjectFromEnv(),
 		"team_id":          "9987654321",
 		"private_key_path": "test-fixtures/private-key.p8",
-		"token_ttl":        "3600s",
+		"token_ttl":        "3900s",
 		"random_suffix":    acctest.RandString(t, 10),
 	}
 
@@ -38,7 +38,7 @@ func TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigU
 		},
 		Steps: []resource.TestStep{
 			{
-				Config: testAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigMinimalExample(context),
+				Config: testAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigFullExample(context),
 			},
 			{
 				ResourceName:            "google_firebase_app_check_device_check_config.default",
@@ -55,15 +55,6 @@ func TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigU
 				ImportStateVerify:       true,
 				ImportStateVerifyIgnore: []string{"private_key", "app_id"},
 			},
-			{
-				Config: testAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigMinimalExample(contextUpdated),
-			},
-			{
-				ResourceName:            "google_firebase_app_check_device_check_config.default",
-				ImportState:             true,
-				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"private_key", "app_id"},
-			},
 		},
 	})
 }