feat: update code based on feedback (take 2)

GoogleCloudPlatform · Dec 12, 2023 · 0be77f7 · 0be77f7
1 parent 5612b2c
commit 0be77f7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/mmv1/products/vertexai/FeatureOnlineStore.yaml b/mmv1/products/vertexai/FeatureOnlineStore.yaml
@@ -43,6 +43,8 @@ examples:
   - !ruby/object:Provider::Terraform::Examples
     name: vertex_ai_feature_online_store
     primary_resource_id: feature_online_store
+    vars:
+      feature_online_store_name: example_feature_online_store
 parameters:
   - !ruby/object:Api::Type::String
     name: region

diff --git a/mmv1/templates/terraform/examples/vertex_ai_feature_online_store.tf.erb b/mmv1/templates/terraform/examples/vertex_ai_feature_online_store.tf.erb
@@ -1,5 +1,5 @@
 resource google_vertex_ai_feature_online_store "<%= ctx[:primary_resource_id] %>" {
-    name = "sample_feature_online_store"
+    name = "<%= ctx[:vars]['feature_online_store_name'] %>"
     region = "us-central1"
     labels = {
         label-one = "value-one"

diff --git a/mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_online_store_test.go b/mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_online_store_test.go
@@ -45,7 +45,7 @@ func TestAccVertexAIFeatureOnlineStore_updated(t *testing.T) {
 func testAccVertexAIFeatureOnlineStore_basic(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource google_vertex_ai_feature_online_store "feature_online_store" {
-    name = "sample_feature_online_store"
+    name = "tf_test_feature_online_store%{random_suffix}"
     region = "us-central1"
     labels = {
         label-one = "value-one"
@@ -65,7 +65,7 @@ resource google_vertex_ai_feature_online_store "feature_online_store" {
 func testAccVertexAIFeatureOnlineStore_updated(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource google_vertex_ai_feature_online_store "feature_online_store" {
-    name = "sample_feature_online_store"
+    name = "tf_test_feature_online_store%{random_suffix}"
     region = "us-central1"
     labels = {
         label-one = "value-one"