Add EdgeNetworkNetwork and EdgeNetworkSubnet resources #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
reviewed
Oct 31, 2023
There was a problem hiding this comment.
May I suggest that for better readability, we could:
- split the first commit into multiple smaller commits. For example, 1 commit for modifying servicemappings and rbacs, etc; 1 commit for the generated files; 1 commit for adding tests and samples.
- instead of having 2 separate commits for "fixing merge conflicts", directly amend the previous commit(s) and do a git force push.
|
@jingyih I've split up the commit history as you requested. Please review. |
jingyih
reviewed
Nov 2, 2023
config/samples/resources/edgenetworksubnet/edgenetwork_v1beta1_edgenetworksubnet.yaml
Outdated
Show resolved
Hide resolved
config/samples/resources/edgenetworksubnet/edgenetwork_v1beta1_edgenetworknetwork.yaml
Outdated
Show resolved
Hide resolved
config/samples/resources/edgenetworknetwork/edgenetwork_v1beta1_edgenetworknetwork.yaml
Outdated
Show resolved
Hide resolved
config/samples/resources/edgenetworksubnet/edgenetwork_v1beta1_edgenetworksubnet.yaml
Outdated
Show resolved
Hide resolved
2 tasks
jingyih
reviewed
Nov 3, 2023
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: f1urps, jingyih The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit d91df41
into
GoogleCloudPlatform:master
6 checks passed
jingyih
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Adds resources for Edge Network API.
Tests you have done
make ready-prto ensure this PR is ready for review.Edge Network API has unique requirements such that integration tests are not possible without a mock.