Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listing ref #3387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Dec 14, 2024

Forgot to actually record the dataExchangeID in a parent for the listing reference. The dynamic post submit caught this but only in testDriftDetection for some reason.

$     go test -v -tags=integration ./pkg/controller/dynamic/ -timeout 1600s -test.count=1 -test.run 'TestCreateNoChangeUpdateDelete/bigqueryanalyticshub/basic-bigqueryanalyticshublisting-base'  2>&1 

...

testreconciler.go:187: reconcile for BigQueryDataset:67ynb4sojpz6wri/bigquerydataset67ynb4sojpz6wri took 493.033563ms, result was ({false 5m48.428911865s}, <nil>)
--- PASS: TestCreateNoChangeUpdateDelete (0.23s)
    --- PASS: TestCreateNoChangeUpdateDelete/bigqueryanalyticshub (0.00s)
        --- PASS: TestCreateNoChangeUpdateDelete/bigqueryanalyticshub/basic-bigqueryanalyticshublisting-base (83.60s)
PASS
...
ok      github.com/GoogleCloudPlatform/k8s-config-connector/pkg/controller/dynamic      93.940s

Signed-off-by: Alex Pana <[email protected]>
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maqiuyujoyce. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants