Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: unify --resource flag format across commands #3376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jingyih
Copy link
Collaborator

@jingyih jingyih commented Dec 12, 2024

Update "generate-controller" and "generate-direct-reconciler" commands to use the same--resource Kind:ProtoName flag format as other commands for consistency in the CLI interface.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuwenma for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingyih jingyih changed the title [WIP] tool: unify --resource flag format across commands tool: unify --resource flag format across commands Dec 12, 2024
Update "generate-controller" and "generate-direct-reconciler" commands to use the same
"--resource Kind:ProtoName" flag format as other commands for consistency in the CLI interface.
@jingyih jingyih force-pushed the refactor_controller_generator branch from 80ea0e7 to 275d08a Compare December 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant