chore: Add backend service reference and refactor reference code #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmahou
commented
Dec 5, 2024
gemmahou
force-pushed
the
backendserviceref
branch
3 times, most recently
from
30c60b8 to
4903616
Compare
gemmahou
changed the title
gemmahou
force-pushed
the
backendserviceref
branch
from
4903616 to
7bfa8ad
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
gemmahou
force-pushed
the
backendserviceref
branch
from
7bfa8ad to
478dd82
Compare
gemmahou
commented
Dec 12, 2024
| external = strings.TrimPrefix(external, "/") | ||
| tokens := strings.Split(external, "/") | ||
| if len(tokens) == 5 && tokens[0] == "projects" && tokens[3] == "backendServices" { | ||
| return &BackendServiceIdentity{ |
There was a problem hiding this comment.
One thought: maybe we could rename ResourceIdentity to ResourceExternal? I feel "Identity" is just the same thing as "ExternalRef", so that we don't introduce many new terms to people.
gemmahou
force-pushed
the
backendserviceref
branch
2 times, most recently
from
23913f8 to
1d5cc2b
Compare
yuwenma
reviewed
Dec 13, 2024
gemmahou
force-pushed
the
backendserviceref
branch
from
1d5cc2b to
b447fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
b/379722657
Use ComputeBackendService as an example, explore how we normalize and resolve referenced resources.
My idea in this PR is to add a
ReferenceContextstruct, developer need to provide info when they try to resolve a referenced resource. Depends on differentReferenceContext, we can handle new referenced resources and ensure backward compatibility at the same time. I plan to add some questions regarding resource reference in the questionnaire.For example, ComputeTargetTCPProxy has reference to ComputeBackendService(BackendServiceRef):
First, developer need to figure out whether ComputeBackendService is a pure direct resource(No); Then they need to know the required value(format) of the field, for ComputeTargetTCPProxy, the value(format) of BackendServiceRef is selfLink(https://www.googleapis.com/compute/v1/projects/${projectId}/global/backendServices/backendService). So their
ReferenceContextlooks likeReferenceContext{IsDirectOnly: false, TargetField: "status.selfLink"}.When they resolve the referenced BackendService in the direct controller, they need to provide the
ReferenceContext, based on their own API requirements. And resolve/convert the value to API required value.In the future, we can add more functions inside
ReferenceContext.I refactored BackendService ref in this PR, and there was no log change.
Tests you have done
make ready-prto ensure this PR is ready for review.