feat: Add note for project dependency gotcha in mockgcp docs #3313
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ah, this is why your project keeps getting deleted? 😄 /lgtm |
| @@ -29,6 +29,12 @@ Create a directory for your resource [pkg/test/resourcefixture/testdata/basic](p | |||
| Just to add the `create.yaml`, `update.yaml` and `dependencies.yaml` (if applicable) to each bottommost directory. | |||
| These three files are all Kubernetes config files, except that `create.yaml` and `update.yaml` only holds the your Config Connector CR object, and the `dependencies.yaml` holds all the dependent objects. | |||
|
|
|||
| Note: Do not add your GCP Project as a dependency in `dependencies.yaml` (even with the `cnrm.cloud.google.com/deletion-policy: abandon` annotation). Adding your project as a dependency will cause Config Connector to add the label `cnrm-test: true` to your project during test runs, which likely not desirable. Instead, you can refer to your development project in the `create.yaml` and `update.yaml` resources via an external project reference, with the `${projectId}` template variable. For example: | |||
There was a problem hiding this comment.
Suggest adding the condition that 1. for hack/record-gcp but not hack/compare-mock. 2. "your GCP project" refers to the default project in gcloud config get project 3. explain a little bit more on what happened to "cnrm-test: true" label.
jasonvigil
force-pushed
the
document-project-dependency-gotcha
branch
from
84c98ad to
a412213
Compare
|
New changes are detected. LGTM label has been removed. |
No description provided.