Add SecureSourceManagerInstance PrivateConfig field API #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ericpang777
force-pushed
the
ssmins-private
branch
from
323d58b to
cdc542c
Compare
ericpang777
commented
Nov 21, 2024
ericpang777
force-pushed
the
ssmins-private
branch
from
93e1ecc to
f46bf6a
Compare
gemmahou
reviewed
Nov 26, 2024
ericpang777
force-pushed
the
ssmins-private
branch
from
d2909b1 to
4c5e5a3
Compare
2 tasks
|
Chain PR off #3270 although it's not really needed |
Signed-off-by: Alex Pana <[email protected]>
Use this new capability to codify the Apigee proto hack that was originally made (manually) in GoogleCloudPlatform#3183. This addresses the suggested change in GoogleCloudPlatform#3183 (review).
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Re-running the type generator and mapper generator for bigquerydatatransferconfig
…ion a reference field
Signed-off-by: Alex Pana <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.