Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip update client in ready-pr #3210

Merged

Conversation

yuwenma
Copy link
Collaborator

@yuwenma yuwenma commented Nov 20, 2024

related to #3037

@maqiuyujoyce
Copy link
Collaborator

/lgtm
/approve

Do we plan to remove the go client generated by make generate-go-client soon?

@yuwenma
Copy link
Collaborator Author

yuwenma commented Nov 20, 2024

/lgtm /approve

Do we plan to remove the go client generated by make generate-go-client soon?

We don't. Here's more details about the plan. I will announce it in 1.126 release.

@maqiuyujoyce
Copy link
Collaborator

Sounds good.

@maqiuyujoyce
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 22, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cc54c3b into GoogleCloudPlatform:master Nov 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants