Use CEL rule to validate field immutability for direct Compute resources #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuwenma
reviewed
Nov 19, 2024
| @@ -102,12 +102,14 @@ type ComputeFirewallPolicyRuleSpec struct { | |||
| // +optional | |||
| EnableLogging *bool `json:"enableLogging,omitempty"` | |||
|
|
|||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="the field is immutable" | |||
There was a problem hiding this comment.
These fields are related to identity. We do not need the immutable check, but set this as required.
There was a problem hiding this comment.
They are required fields now. If no immutable check is needed, we can close this PR.
|
No immutability checks on fields are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
b/377531379
Checked all three direct compute resources(forwarding rule, firewall policy rule, target tcp proxy), added CEL rule on the immutable and required fields, following https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/docs/develop-resources/api-conventions/validations.md#option-2
Note: We haven't turned on direct reconciliation for those compute resources yet, instead, we use the "alpha.cnrm.cloud.google.com/reconciler: "direct"" annotation to opt-in. So they are still protected by the immutable webhook for now.
Tests you have done
make ready-prto ensure this PR is ready for review.