test: Add test case for reference regional target tcp proxy in CFR #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmahou
force-pushed
the
reference-regional-tcp
branch
2 times, most recently
from
956987a to
852d1e5
Compare
gemmahou
force-pushed
the
reference-regional-tcp
branch
6 times, most recently
from
0e09f51 to
8c02d43
Compare
|
No diffs in commit are related to forwarding rule or tcp proxy |
gemmahou
force-pushed
the
reference-regional-tcp
branch
from
956e8f9 to
780d80c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gemmahou
force-pushed
the
reference-regional-tcp
branch
from
dbae7f1 to
0a82f6a
Compare
yuwenma
reviewed
Dec 12, 2024
| @@ -87,7 +87,7 @@ type ComputeTargetTCPProxyObservedState struct { | |||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
| // +kubebuilder:resource:categories=gcp,shortName=gcpcomputetargettcpproxy;gcpcomputetargettcpproxies | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:metadata:labels="cnrm.cloud.google.com/tf2crd=true";"cnrm.cloud.google.com/stability-level=stable";"cnrm.cloud.google.com/managed-by-kcc=true";"cnrm.cloud.google.com/system=true" | |||
| // +kubebuilder:metadata:labels="cnrm.cloud.google.com/stability-level=stable";"cnrm.cloud.google.com/managed-by-kcc=true";"cnrm.cloud.google.com/system=true" | |||
There was a problem hiding this comment.
Let's not turn off the TF-based controller in this PR
There was a problem hiding this comment.
Done. Let's enable regional TCP Proxy first #3323 before merging this PR.
gemmahou
force-pushed
the
reference-regional-tcp
branch
2 times, most recently
from
067dffb to
2361ea9
Compare
gemmahou
force-pushed
the
reference-regional-tcp
branch
from
2361ea9 to
44f85c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
based on #3047, #3112
Add additional test case for compute forwarding rule, verify that it can now reference to a regional tcp proxy
Tests you have done
make ready-prto ensure this PR is ready for review.