Spanner instance direct controller #3137
Conversation
anhdle-sso
force-pushed
the
spanner_instance_mapper
branch
5 times, most recently
from
bc06e0f to
cb1912f
Compare
anhdle-sso
force-pushed
the
spanner_instance_mapper
branch
from
cb1912f to
3e25f08
Compare
anhdle-sso
force-pushed
the
spanner_instance_mapper
branch
from
3e25f08 to
181088a
Compare
anhdle-sso
changed the title
...sions.k8s.io_v1_customresourcedefinition_spannerinstances.spanner.cnrm.cloud.google.com.yaml
Show resolved
Hide resolved
hack/record-gcp
Outdated
| @@ -27,7 +27,7 @@ echo "TEST_BILLING_ACCOUNT_ID=${TEST_BILLING_ACCOUNT_ID}" | |||
| export TEST_BILLING_ACCOUNT_ID | |||
|
|
|||
| if [[ -z "${KCC_USE_DIRECT_RECONCILERS:-}" ]]; then | |||
| KCC_USE_DIRECT_RECONCILERS="ComputeForwardingRule" | |||
| KCC_USE_DIRECT_RECONCILERS="ComputeForwardingRule,SpannerInstance" | |||
There was a problem hiding this comment.
Suggest not changing this env var. We don't run real gcp against presubmit, so this is more like a local setup.
There was a problem hiding this comment.
ack, I added this to run with real gcp, I can take it out here
| "nodeCount": 3, | ||
| "processingUnits": 2000 | ||
| "name": "projects/${projectId}/instances/spannerinstance-sample-${uniqueId}", | ||
| "nodeCount": 3 |
| resourceID := direct.ValueOf(obj.Spec.ResourceID) | ||
| if resourceID == "" { | ||
| resourceID = obj.GetName() | ||
| } | ||
| if resourceID == "" { | ||
| return nil, fmt.Errorf("cannot resolve resource ID") | ||
| } |
There was a problem hiding this comment.
This should be from the NewSpannerInstanceRef
| return mapCtx.Err() | ||
| } | ||
|
|
||
| updateMask := &fieldmaskpb.FieldMask{} |
There was a problem hiding this comment.
Suggest using the common.CompareProtoMessage here?
There was a problem hiding this comment.
with the weird computing fields behaviors (unset, unmanaged, swap), I would keep the check to be manual as we have been doing before.
There was a problem hiding this comment.
Oh I see, right... Is nodeCount and processingUnit the only two fields have defaulting values in SpannerInstance?
There was a problem hiding this comment.
BTW, we can improve the CompareProtoMessage to apply comparison with customized conditions.
anhdle-sso
force-pushed
the
spanner_instance_mapper
branch
from
f64c2ae to
c0f4723
Compare
...sions.k8s.io_v1_customresourcedefinition_spannerinstances.spanner.cnrm.cloud.google.com.yaml
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit da53ff0
into
GoogleCloudPlatform:master
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.