-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate bigquerydataset to new API #3125
base: master
Are you sure you want to change the base?
migrate bigquerydataset to new API #3125
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b4ebd5e
to
956f9e8
Compare
/assign @jingyih |
956f9e8
to
fe0c30a
Compare
pkg/controller/direct/bigquerydataset/bigquerydataset_mappings.go
Outdated
Show resolved
Hide resolved
pkg/controller/direct/bigquerydataset/bigquerydataset_mappings.go
Outdated
Show resolved
Hide resolved
pkg/controller/direct/bigquerydataset/bigquerydataset_mappings.go
Outdated
Show resolved
Hide resolved
fe0c30a
to
f8e8acd
Compare
2704d04
to
4b70b84
Compare
4b70b84
to
a2da914
Compare
desired *krm.BigQueryDataset | ||
actual *bigquery.DatasetMetadata | ||
reader client.Reader | ||
hasUpdateIsCaseInsensitive bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I follow, what does hasUpdateIsCaseInsensitive
do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In go, explicitly set a bool value to false and not setting it (it defaults to false), there is not a method to tell the difference. I added it here to tell if the update has explicitly set the value to false, therefore I should update this field. Or it only defaults to false, where I should not be updating it.
a2da914
to
ff3b040
Compare
Github diff tool is not working correctly. The actual diff on http log: |
The New BigQuery API does not support the field
isCaseSensitive
.Update: Filed a feature request with the bigquery team and the field has been added. Reference PR: googleapis/google-cloud-go#11216. Reference BigQuery version: https://github.com/googleapis/google-cloud-go/releases/tag/bigquery/v1.65.0
make ready-pr
to ensure this PR is ready for review.