Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate bigquerydataset to new API #3125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaoweim
Copy link
Collaborator

@xiaoweim xiaoweim commented Nov 7, 2024

The New BigQuery API does not support the field isCaseSensitive.

Update: Filed a feature request with the bigquery team and the field has been added. Reference PR: googleapis/google-cloud-go#11216. Reference BigQuery version: https://github.com/googleapis/google-cloud-go/releases/tag/bigquery/v1.65.0

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaoweim xiaoweim force-pushed the migrate_bigquerydataset_new_API branch 4 times, most recently from b4ebd5e to 956f9e8 Compare November 12, 2024 22:41
@xiaoweim xiaoweim changed the title [WIP] migration bigquerydataset to new API migrate bigquerydataset to new API Nov 12, 2024
@xiaoweim
Copy link
Collaborator Author

/assign @jingyih

@xiaoweim xiaoweim force-pushed the migrate_bigquerydataset_new_API branch from 956f9e8 to fe0c30a Compare November 12, 2024 23:39
@xiaoweim xiaoweim force-pushed the migrate_bigquerydataset_new_API branch from 4b70b84 to a2da914 Compare December 12, 2024 21:09
desired *krm.BigQueryDataset
actual *bigquery.DatasetMetadata
reader client.Reader
hasUpdateIsCaseInsensitive bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow, what does hasUpdateIsCaseInsensitive do?

Copy link
Collaborator Author

@xiaoweim xiaoweim Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In go, explicitly set a bool value to false and not setting it (it defaults to false), there is not a method to tell the difference. I added it here to tell if the update has explicitly set the value to false, therefore I should update this field. Or it only defaults to false, where I should not be updating it.

@xiaoweim xiaoweim force-pushed the migrate_bigquerydataset_new_API branch from a2da914 to ff3b040 Compare December 12, 2024 23:51
@jingyih
Copy link
Collaborator

jingyih commented Dec 13, 2024

Github diff tool is not working correctly. The actual diff on http log:

_http5.log
_http6.log
_http7.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants