refactor normalization #3086
Merged
refactor normalization #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Nov 4, 2024
justinsb
commented
- tests: replace folder & org more consistently
- tests: update golden output for more replacements
yuwenma
reviewed
Nov 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
refactor_normalization
branch
from
3e024da to
f73cc28
Compare
|
Could you resolve the merge conflict? |
justinsb
force-pushed
the
refactor_normalization
branch
from
f73cc28 to
e356d64
Compare
Pass it into the generic normalization function, and then replace them in the values, rather than doing a simple string replacement.
justinsb
force-pushed
the
refactor_normalization
branch
from
e356d64 to
df7a07e
Compare
|
Merge conflict resolved :-) |
|
/lgtm |
google-oss-prow
bot
merged commit 6361db7
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.