Promoting autokey config from alpha to beta #3012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
reviewed
Oct 28, 2024
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| 1. In [config/samples/resources](config/samples/resources), create a new | |||
| directory for the resource's samples: `mkdir spannerinstance`. | |||
| 1. Follow the sample guidelines [here](../../README.Samples.md) and create sample(s) for the resource. | |||
| 1. Follow the sample guidelines [here](../../../README.Samples.md) and create sample(s) for the resource. | |||
This reverts commit db81600.
Turns out, we need to set a default value for the IpConfiguration fields for Ipv4Enabled and SslMode, even if some of the IpConfiguration is specified. Also, SslMode appears to have a different default value depending on which type of database is used.
yuwenma
reviewed
Oct 29, 2024
pkg/controller/direct/kms/autokeyconfig/autokeyconfig_controller.go
Outdated
Show resolved
Hide resolved
3 tasks
This avoids the non-determinism
It isn't (normally) an error, we're just waiting for the webhook to start.
The IAMPolicy samples and IAMPartialPolicy samples had the same name, causing our test results to be ambiguous. Rename to deduplicate.
We probably should have an override capability, but .... this works.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit e527685.
part2 alpha to beta autokeyconfig Part3 updated part 4 part 5 Part 6 Part 7 part 8 Review commetns correcting unit test build error Make ready pr Updating gvk_generated.go removing accidental file Make readypr init for dummy branch Revert "init for dummy branch" This reverts commit db81600. initial key handle commit delete accidentally committed files Make ready-pr Removing todos updating tests Updated as per bigquery connection controller addressing review comments real gcp logs minor nits use update field mask to deterine which field to update real gcp record mock gcp fix: cbwp GCP server request/response project in different format chore: rename projectIDAndNumber build project ID and Number switcher around NetworkRef Promote PrivilegedAccessManagerEntitlement to v1beta1 Rerun 'make ready-pr'" Run 'make ensure' removing apis/kms/v1alpha1 Revert "removing apis/kms/v1alpha1" This reverts commit e527685. removing autokeyconfig from v1alpha1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.