DiscoveryEngineDataStore: mockgcp support #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Oct 24, 2024
•
justinsb
commented
- DiscoveryEngineDataStore: mockgcp support
- mockgcp: generate code for discoveryengine
- DiscoveryEngineDataStore: protos for mockgcp
- DiscoveryEngineDataStore: golden output for mockgcp
|
/approve The mock gcp part (last 3 commits) looks good. Waiting for the diff base PR to merge |
justinsb
force-pushed
the
discoveryenginedatastore_mockgcp
branch
from
6b3b111 to
fa734c8
Compare
|
/lgtm |
justinsb
force-pushed
the
discoveryenginedatastore_mockgcp
branch
from
fa734c8 to
3d38bf6
Compare
yuwenma
reviewed
Oct 31, 2024
| @@ -56,8 +56,7 @@ X-Xss-Protection: 0 | |||
| "defaultSchemaId": "default_schema", | |||
| "displayName": "My first data store", | |||
| "industryVertical": 1, | |||
| "name": "projects/${projectNumber}/locations/global/collections/default_collection/dataStores/datastore-${uniqueId}", | |||
| "servingConfigDataStore": {} | |||
There was a problem hiding this comment.
I think we want this servingConfigDataStore field showing in the GCP object.
There was a problem hiding this comment.
It's not in the protos yet (at least not that I could find)
yuwenma
reviewed
Oct 31, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
discoveryenginedatastore_mockgcp
branch
from
3d38bf6 to
5c6e1d7
Compare
|
/lgtm |
google-oss-prow
bot
merged commit f17f547
into
GoogleCloudPlatform:master
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.