-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DiscoveryEngineDataStore: types, mappers and fuzzers #3000
Merged
google-oss-prow
merged 8 commits into
GoogleCloudPlatform:master
from
justinsb:crd_for_discoveryenginedatastore
Oct 25, 2024
Merged
DiscoveryEngineDataStore: types, mappers and fuzzers #3000
google-oss-prow
merged 8 commits into
GoogleCloudPlatform:master
from
justinsb:crd_for_discoveryenginedatastore
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Oct 24, 2024
- tests: create generic fuzz tester
- chore: controllerbuilder better handling for enum slices
- chore: enhanced fuzzing support for enum lists and bytes
- DiscoveryEngineDataStore: types and mappers
- autogen: DiscoveryEngineDataStore
- DiscoveryEngineDataStore: fuzzers
- fuzzers: handle more types in visitor
- DiscoveryEngineDataStore: update go.mod / go.sum
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
crd_for_discoveryenginedatastore
branch
from
October 24, 2024 20:27
38d8f29
to
2699d8a
Compare
justinsb
force-pushed
the
crd_for_discoveryenginedatastore
branch
from
October 24, 2024 23:05
099667d
to
5371b3e
Compare
/lgtm |
google-oss-prow
bot
merged commit Oct 25, 2024
c819ea7
into
GoogleCloudPlatform:master
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.