Mockgcp test for autokey config #2755
Conversation
|
@nb-goog Can you follow this guide https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/docs/archive/README.NewResourceFromTerraform.md#add-necessary-yaml-files-to-testdata to add the basic and full test suites? This is the requirements to kick off a PR review and validate the Direct resource development as described here https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/docs/develop-resources/scenarios |
1. updated controller to return false iff get return 404 2. updated mappers
pkg/controller/direct/privilegedaccessmanager/entitlement_controller.go
Outdated
Show resolved
Hide resolved
|
That will be scenario based testing right? |
pkg/test/resourcefixture/testdata/basic/kms/v1alpha1/kmsautokeyconfig/update.yaml
Outdated
Show resolved
Hide resolved
pkg/controller/direct/kms/autokeyconfig/autokeyconfig_controller.go
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
Add the container.cnrm.cloud.google.com API group to the e2e tests.
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Add mockgcp tests for kms autokeyconfig resource
make ready-prto ensure this PR is ready for review.