Remove aws and azure support for BigQueryConnectionConnection #2341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
A couple of reasons why we should remove the aws and azure support in BigQueryConnectionConnection:
spec.aws
andspec.azure
fields. We need to handle them specially.Considering that there is no urgent request about those features, and BigQueryConnectionConnection is still a v1alpha1 kind, let's remove the aws and azure fields for now and only add them after we can support thorough testing.
Tests you have done
make ready-pr
to ensure this PR is ready for review.Note that an unrelated CRD actually got generated when running
make ready-pr
: #2339