Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws and azure support for BigQueryConnectionConnection #2341

Conversation

maqiuyujoyce
Copy link
Collaborator

Change description

A couple of reasons why we should remove the aws and azure support in BigQueryConnectionConnection:

  1. There are a few output-only fields under the top-level spec.aws and spec.azure fields. We need to handle them specially.
  2. There is no test coverage for the aws or the azure support, but testing it out means we need to set up accounts in both AWS and Azure. This may be expensive.

Considering that there is no urgent request about those features, and BigQueryConnectionConnection is still a v1alpha1 kind, let's remove the aws and azure fields for now and only add them after we can support thorough testing.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.

Note that an unrelated CRD actually got generated when running make ready-pr: #2339

  • [N/A] Perform necessary E2E testing for changed resources.

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for the change. Nice to see some VRD exceptions are cleared out.

@google-oss-prow google-oss-prow bot added the lgtm label Jul 24, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7d5aaa8 into GoogleCloudPlatform:master Jul 24, 2024
13 checks passed
@yuwenma yuwenma added this to the 1.121 milestone Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants