mockgcp: more fidelity for secretmanager #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Jul 19, 2024
justinsb
commented
- mockgcp: update secretmanager
- mockgcp: update fidelity of secretmanager API
- tests: add updated golden output for secretmanager
justinsb
force-pushed
the
mockgcp_fidelity_secret
branch
from
832f403 to
61c697c
Compare
|
This is because the automatic update PR #2311 was failing because we were (incorrectly) responding with all fields for secret manager from mockgcp. |
justinsb
force-pushed
the
mockgcp_fidelity_secret
branch
from
98e0f29 to
d74bc95
Compare
cheftako
reviewed
Jul 22, 2024
| hasConditions := false | ||
| for _, binding := range request.Policy.Bindings { | ||
| if binding.Condition != nil { | ||
| hasConditions = true |
There was a problem hiding this comment.
might as well break at this point. No point in going through the rest of the bindings....
cheftako
reviewed
Jul 22, 2024
cheftako
reviewed
Jul 22, 2024
cheftako
reviewed
Jul 22, 2024
...t/resourcefixture/testdata/basic/alloydb/v1beta1/alloydbcluster/fullalloydbcluster/_http.log
Show resolved
Hide resolved
|
Looks good. Would like answers for Policy.Version and projectId before making it official. |
These scenarios use setIamPolicy / getIamPolicy (predominantly), and those methods now (correctly) return headers with our mock.
justinsb
force-pushed
the
mockgcp_fidelity_secret
branch
from
d74bc95 to
1773460
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 042ce34
into
GoogleCloudPlatform:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.