Support mockgcp for BigQueryConnectionConnection #2315
Conversation
maqiuyujoyce
added
do-not-merge/work-in-progress
and removed
do-not-merge/work-in-progress
labels
|
Hmmm... why are the tests not running.... /ok-to-test |
|
|
||
| // The returned "name" in the response uses the project number instead of | ||
| // project ID. | ||
| obj.Name = strings.ReplaceAll(fqn, "mock-project", "${projectNumber}") |
There was a problem hiding this comment.
Nit: I'm not sure we always use mock-project, it's probably easier to copy the fmt.Sprintf line and adapt it
There was a problem hiding this comment.
Updated. Now it doesn't care what project ID it is.
|
Looks great. I'm a little scared that the tests don't seem to be running though... |
The first run of the test suite never finish for some reason: https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/9999441455 I tried to cancel the workflow multiple times yesterday but it didn't work. I was wondering if it is the problem of GitHub... |
|
Yes, looks like github actions had a whoopsie yesterday: https://www.githubstatus.com/history Want to try rebasing and force pushing? |
|
Will do! |
…Query connection API
maqiuyujoyce
force-pushed
the
202407-bqcc-mockgcp
branch
from
3852aa8 to
bf146c1
Compare
|
Awesome - thanks @maqiuyujoyce /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit cdf43aa
into
GoogleCloudPlatform:master
Change description
Support mockgcp to talk to BigQuery Connection v1 API.
Tests you have done
make ready-prto ensure this PR is ready for review.E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock GOLDEN_REQUEST_CHECKS=1 GOLDEN_OBJECT_CHECKS=1 go test -test.count=1 -timeout 3600s -v ./tests/e2e -run TestAllInSeries/fixtures/bigqueryconnectionconnectionpassed.