fix: guard against nil model #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/fix-direct-test
branch
from
8fa12b3 to
89f4b9b
Compare
justinsb
reviewed
Jun 20, 2024
| @@ -39,7 +39,7 @@ type ModelFactoryFunc func(ctx context.Context, config *config.ControllerConfig) | |||
|
|
|||
| func GetModel(gk schema.GroupKind) (directbase.Model, error) { | |||
| registration := singleton.registrations[gk] | |||
| if registration == nil { | |||
| if registration == nil || registration.model == nil { | |||
There was a problem hiding this comment.
We could also test this one separately and say "Init not called" (I guess?)
justinsb
approved these changes
Jun 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 30b7d89
into
GoogleCloudPlatform:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
models for the dynamic controller presubmits are nil bc we neverInitthe registry. This also proved to me that we probably want to error out inAddControllerifmodelis nil for agvk. Finally, if theregistrationfor agkcontains anilmodel, we probably want to err out to signal to consumers thatInitwas not called.