Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update protobuf libraries #2052

Merged

Conversation

justinsb
Copy link
Collaborator

No description provided.

@barney-s
Copy link
Collaborator

@justinsb - Do you mind running "make build-protos" and if there are changes in the proto files add it as part of the commit,

@justinsb justinsb force-pushed the update_protobuf_libraries branch from 41be10f to a644b50 Compare June 18, 2024 21:03
@justinsb
Copy link
Collaborator Author

Do you mind running "make build-protos" and if there are changes in the proto files add it as part of the commit,

I'm happy to do that, but I don't think it's related to this PR, so I can do it separately

@justinsb justinsb force-pushed the update_protobuf_libraries branch 3 times, most recently from 97685a5 to f13a4f5 Compare June 20, 2024 21:07
@justinsb justinsb force-pushed the update_protobuf_libraries branch from f13a4f5 to 63e725c Compare June 20, 2024 21:16
@yuwenma
Copy link
Collaborator

yuwenma commented Jun 21, 2024

/lgtm
/approve

I missed this one before, thinking it was for the composition only

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f03a638 into GoogleCloudPlatform:master Jun 21, 2024
17 checks passed
@yuwenma yuwenma added this to the 1.120 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants