feat: templating tool for direct controller builder #1996
Conversation
yuwenma
force-pushed
the
controller-builder
branch
from
b7a8fe4 to
6c9f55f
Compare
yuwenma
force-pushed
the
controller-builder
branch
from
6c9f55f to
6766368
Compare
| return controllerFilePath, nil | ||
| } | ||
|
|
||
| func FormatImports(path string, out []byte) error { |
| } | ||
|
|
||
| func WriteToFile(path string, out []byte) error { | ||
| f, err := os.Create(path) |
There was a problem hiding this comment.
Nit: I don't think you need (or should) call os.Create here. os.WriteFile creates the file IIRC.
There was a problem hiding this comment.
(If you want to check that the file doesn't exist, you should basically inline WriteFile, passing some different options to os.OpenFile IIRC)
| } | ||
|
|
||
| func WriteToFile(path string, out []byte) error { | ||
| f, err := os.Create(path) |
There was a problem hiding this comment.
(If you want to check that the file doesn't exist, you should basically inline WriteFile, passing some different options to os.OpenFile IIRC)
|
Looks great. Once we have a template we can start adding commands / tweaking the template as we see fit. Really happy to see this 🎉 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 04064f0
into
GoogleCloudPlatform:master
Example
cd dev/tools/controllerbuilder