tests: capture GRPC traffic also #1655
Conversation
justinsb
commented
Apr 26, 2024
justinsb
commented
- tfprovider: support intercepting GRPC requests
- tests: record grpc requests in our golden tests
- tests: capture golden output for bigtabletable test
justinsb
force-pushed
the
capture_grpc
branch
2 times, most recently
from
712924c to
87c076f
Compare
There was a problem hiding this comment.
This probably needs to be called something else then, right? Like _grpc.golden.log ?
There was a problem hiding this comment.
maybe ... the issue is that it's still http traffic, we're just decoding the GRPC requests. There are some http logs where we intermingle http and GRPC!
There was a problem hiding this comment.
We could maybe rename _http.log to _requests.log or _gcp.log - it's really the log of non-kube requests/responses.
There was a problem hiding this comment.
I think keeping the name as it is should be good. From the testing level, it doesn't really matter where the resource comes from or talks to. We care more on the resource itself.
| @@ -32,6 +33,10 @@ func (s BigtableClientFactory) NewInstanceAdminClient(project string) (*bigtable | |||
| opts = append(opts, option.WithTokenSource(s.TokenSource), option.WithUserAgent(s.UserAgent)) | |||
| opts = append(opts, s.gRPCLoggingOptions...) | |||
|
|
|||
| if GRPCUnaryClientInterceptor != nil { | |||
There was a problem hiding this comment.
Is this change from the upstream tf repo fetch or we manually added the logic?
|
/lgtm The fail test looks suspicious. Could you rerun? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We aim to construct a readable version of the GRPC requests.
This uses our new GRPC collection infrastructure.
|
/lgtm |
google-oss-prow
bot
merged commit 040ef44
into
GoogleCloudPlatform:master
