Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to go 1.22.3 #1513

Merged

Conversation

justinsb
Copy link
Collaborator

@justinsb justinsb commented Apr 5, 2024

  • Update our go.mod to use toolchain
  • Make sure dockerfiles are using pinned versions
  • Set the version to 1.22.3

@justinsb justinsb force-pushed the bump_golang_1_22_2 branch 4 times, most recently from 73780e2 to 5733048 Compare April 10, 2024 19:49
@justinsb justinsb force-pushed the bump_golang_1_22_2 branch from 5733048 to b9d8b86 Compare April 23, 2024 02:42
@justinsb justinsb force-pushed the bump_golang_1_22_2 branch from b9d8b86 to 60597e5 Compare May 7, 2024 00:48
@justinsb
Copy link
Collaborator Author

justinsb commented May 7, 2024

/assign @yuwenma

@justinsb
Copy link
Collaborator Author

justinsb commented May 7, 2024

I think this needs the bump in #1700 ... I'll merge that one in here to be sure.

@justinsb justinsb force-pushed the bump_golang_1_22_2 branch from 60597e5 to 38acb9b Compare May 7, 2024 02:05
@justinsb
Copy link
Collaborator Author

justinsb commented May 7, 2024

The bump in #1700 means this one does now pass tests, so I think we need #1700 and then I can rebase this one (or we can just merge this one)

@yuwenma
Copy link
Collaborator

yuwenma commented May 7, 2024

/lgtm

Personally I'd prefer merging #1700 first so that people can tell how to bump a controller-gen and which files are affected in the future when we need to. Defer to you.

@google-oss-prow google-oss-prow bot added the lgtm label May 7, 2024
@justinsb justinsb force-pushed the bump_golang_1_22_2 branch from 38acb9b to c52366b Compare May 8, 2024 16:01
@google-oss-prow google-oss-prow bot removed the lgtm label May 8, 2024
@justinsb justinsb force-pushed the bump_golang_1_22_2 branch from c52366b to 369d342 Compare May 8, 2024 16:14
justinsb added 2 commits May 8, 2024 12:16
* Update our go.mod to use toolchain
* Make sure dockerfiles are using pinned versions
* Set the version to 1.22.3
This looks like it is now a blocker in 1.22.2 (?)
@justinsb justinsb force-pushed the bump_golang_1_22_2 branch from 369d342 to fb78327 Compare May 8, 2024 16:16
@justinsb justinsb changed the title chore: update to go 1.22.2 chore: update to go 1.22.3 May 8, 2024
@yuwenma
Copy link
Collaborator

yuwenma commented May 8, 2024

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Collaborator

yuwenma commented May 8, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 8, 2024
@google-oss-prow google-oss-prow bot merged commit d2ac619 into GoogleCloudPlatform:master May 8, 2024
12 checks passed
@yuwenma yuwenma added this to the 1.117 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants