[WIP] Backport Add cross-region replication support to AlloyDB #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport hashicorp/terraform-provider-google-beta#6474 To Create a Secondary Cluster, `cluster_type` and `secondary_config` are the additional fields to be mentioned in the cluster. The secondary cluster is dependent on the primary instance and the same needs to be added in the config using the `depends_on` field. The field continuous_backup_config.enabled needs to be set false as continuous backup is not supported for secondary clusters. The deletion_policy is set to FORCE as the secondary instance that will be created in the secondary cluster can not be deleted independently, but instead the entire secondary cluster needs to be deleted forcefully along with its secondary instance. ``` cluster_type = "SECONDARY" deletion_policy = "FORCE" secondary_config { primary_cluster_name = <fully qualified primary cluster name> // Eg: primary_cluster_name = google_alloydb_cluster.<primary_cluster_name>.name } continuous_backup_config { enabled = false } depends_on = [google_alloydb_instance.<primary_instance_name>] ``` Part of [hashicorp/terraform-provider-google#13251](hashicorp/terraform-provider-google#13251) **Release Note Template for Downstream PRs (will be copied)** ``` alloydb: added `cluster_type` and `secondary_config` fields to support secondary clusters in `google_alloydb_cluster` resource. ``` Derived from [GoogleCloudPlatform/magic-modules#9012](GoogleCloudPlatform/magic-modules#9012)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This would be surprising to users!
Backport hashicorp/terraform-provider-google-beta#6474 To Create a Secondary Cluster, `cluster_type` and `secondary_config` are the additional fields to be mentioned in the cluster. The secondary cluster is dependent on the primary instance and the same needs to be added in the config using the `depends_on` field. The field continuous_backup_config.enabled needs to be set false as continuous backup is not supported for secondary clusters. The deletion_policy is set to FORCE as the secondary instance that will be created in the secondary cluster can not be deleted independently, but instead the entire secondary cluster needs to be deleted forcefully along with its secondary instance. ``` cluster_type = "SECONDARY" deletion_policy = "FORCE" secondary_config { primary_cluster_name = <fully qualified primary cluster name> // Eg: primary_cluster_name = google_alloydb_cluster.<primary_cluster_name>.name } continuous_backup_config { enabled = false } depends_on = [google_alloydb_instance.<primary_instance_name>] ``` Part of [hashicorp/terraform-provider-google#13251](hashicorp/terraform-provider-google#13251) **Release Note Template for Downstream PRs (will be copied)** ``` alloydb: added `cluster_type` and `secondary_config` fields to support secondary clusters in `google_alloydb_cluster` resource. ``` Derived from [GoogleCloudPlatform/magic-modules#9012](GoogleCloudPlatform/magic-modules#9012)
cheftako
commented
Mar 25, 2024
| @@ -183,7 +182,7 @@ func registerDefaultController(r *ReconcileRegistration, config *controller.Conf | |||
| } | |||
| return schemaUpdater, nil | |||
| default: | |||
| klog.Warningf("requested direct reconciler for %v, but it is not supported", gvk.GroupKind()) | |||
There was a problem hiding this comment.
Not sure what/why this changed.
|
Is it the same as #1377 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Backport hashicorp/terraform-provider-google-beta#6474
To Create a Secondary Cluster,
cluster_typeandsecondary_configare the additional fields to be mentioned in the cluster. The secondary cluster is dependent on the primary instance and the same needs to be added in the config using thedepends_onfield. The field continuous_backup_config.enabled needs to be set false as continuous backup is not supported for secondary clusters. The deletion_policy is set to FORCE as the secondary instance that will be created in the secondary cluster can not be deleted independently, but instead the entire secondary cluster needs to be deleted forcefully along with its secondary instance.Part of hashicorp/terraform-provider-google#13251
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9012
Fixes #
Tests you have done
None
make ready-prto ensure this PR is ready for review.