Skip to content

Commit

Permalink
Merge pull request #1388 from justinsb/dont_change_test_name
Browse files Browse the repository at this point in the history
chore: avoid changing name of tests
  • Loading branch information
google-oss-prow[bot] authored Mar 18, 2024
2 parents 778ec33 + 72bc251 commit bd1977f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/e2e/unified_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func TestAllInSeries(t *testing.T) {
}
})

testFixturesInSeries(ctx, t, "AllInSeries", false, cancel)
testFixturesInSeries(ctx, t, false, cancel)
}

// TestPauseInSeries is a basic smoke test to prove that if CC pauses actuation of resources
Expand All @@ -96,10 +96,10 @@ func TestPauseInSeries(t *testing.T) {
cancel()
})

testFixturesInSeries(ctx, t, "PauseInSeries", true, cancel)
testFixturesInSeries(ctx, t, true, cancel)
}

func testFixturesInSeries(ctx context.Context, t *testing.T, testName string, testPause bool, cancel context.CancelFunc) {
func testFixturesInSeries(ctx context.Context, t *testing.T, testPause bool, cancel context.CancelFunc) {
t.Helper()

if os.Getenv("RUN_E2E") == "" {
Expand All @@ -109,7 +109,7 @@ func testFixturesInSeries(ctx context.Context, t *testing.T, testName string, te
t.Skip("GOLDEN_REQUEST_CHECKS not set; skipping as this test relies on the golden files.")
}

t.Run(fmt.Sprintf("%s/fixtures", testName), func(t *testing.T) {
t.Run("fixtures", func(t *testing.T) {
fixtures := resourcefixture.Load(t)
for _, fixture := range fixtures {
fixture := fixture
Expand Down

0 comments on commit bd1977f

Please sign in to comment.