-
Notifications
You must be signed in to change notification settings - Fork 237
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3185 from yuwenma/single-cmd
feat: a simple cmd to add a basic scifi reconciler
- Loading branch information
Showing
7 changed files
with
206 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
dev/tools/controllerbuilder/pkg/commands/generatedirectreconciler/command.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| // Copyright 2024 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package generatedirectreconciler | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "os" | ||
|
|
||
| "github.com/GoogleCloudPlatform/k8s-config-connector/dev/tools/controllerbuilder/pkg/commands/generatecontroller" | ||
| "github.com/GoogleCloudPlatform/k8s-config-connector/dev/tools/controllerbuilder/pkg/commands/generatemapper" | ||
| "github.com/GoogleCloudPlatform/k8s-config-connector/dev/tools/controllerbuilder/pkg/commands/generatetypes" | ||
| "github.com/GoogleCloudPlatform/k8s-config-connector/dev/tools/controllerbuilder/pkg/options" | ||
| "github.com/spf13/cobra" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| ) | ||
|
|
||
| type GenerateBasicReconcilerOptions struct { | ||
| *options.GenerateOptions | ||
| Kind string | ||
| ProtoName string | ||
| // OutputAPIDirectory string | ||
|
|
||
| APIGoPackagePath string | ||
| APIDirectory string | ||
| OutputMapperDirectory string | ||
| } | ||
|
|
||
| func (o *GenerateBasicReconcilerOptions) BindFlags(cmd *cobra.Command) { | ||
| cmd.Flags().StringVarP(&o.ProtoName, "proto-resource", "p", "", "the GCP resource proto name. It should match the name in the proto apis. i.e. For resource google.storage.v1.bucket, the `--proto-resource` should be `bucket`. If `--kind` is not given, the `--proto-resource` value will also be used as the kind name with a capital letter `Storage`.") | ||
| cmd.Flags().StringVarP(&o.Kind, "kind", "k", "", "the KCC resource Kind. requires `--proto-resource`.") | ||
| // cmd.Flags().StringVar(&o.OutputAPIDirectory, "output-api", o.OutputAPIDirectory, "base directory for writing APIs") | ||
| cmd.Flags().StringVar(&o.APIGoPackagePath, "api-go-package-path", o.APIGoPackagePath, "package path") | ||
| cmd.Flags().StringVar(&o.APIDirectory, "api-dir", o.APIDirectory, "base directory for reading APIs") | ||
| cmd.Flags().StringVar(&o.OutputMapperDirectory, "output-dir", o.OutputMapperDirectory, "base directory for writing mappers") | ||
| } | ||
|
|
||
| func (o *GenerateBasicReconcilerOptions) InitDefaults() error { | ||
| root, err := options.RepoRoot() | ||
| if err != nil { | ||
| return nil | ||
| } | ||
| o.ProtoSourcePath = root + "/dev/tools/proto-to-mapper/build/googleapis.pb" | ||
| o.APIGoPackagePath = "github.com/GoogleCloudPlatform/k8s-config-connector/apis/" | ||
| o.APIDirectory = root + "/apis/" | ||
| // o.OutputAPIDirectory = root + "/apis/" | ||
| o.OutputMapperDirectory = root + "/pkg/controller/direct/" | ||
| return nil | ||
| } | ||
|
|
||
| func BuildCommand(baseOptions *options.GenerateOptions) *cobra.Command { | ||
| opt := &GenerateBasicReconcilerOptions{ | ||
| GenerateOptions: baseOptions, | ||
| } | ||
|
|
||
| if err := opt.InitDefaults(); err != nil { | ||
| fmt.Fprintf(os.Stderr, "Error initializing defaults: %v\n", err) | ||
| os.Exit(1) | ||
| } | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "generate-direct-reconciler", | ||
| Short: "[ALPHA] generate a basic direct reconciler that is up and run", | ||
| PreRunE: func(cmd *cobra.Command, args []string) error { | ||
| if opt.Kind == "" { | ||
| return fmt.Errorf("--kind is required") | ||
| } | ||
| if opt.ProtoName == "" { | ||
| return fmt.Errorf("--proto-resource is required") | ||
| } | ||
| if baseOptions.APIVersion == "" { | ||
| return fmt.Errorf("--api-version is required") | ||
| } | ||
| _, err := schema.ParseGroupVersion(baseOptions.APIVersion) | ||
| if err != nil { | ||
| return fmt.Errorf("unable to parse --api-version: %w", err) | ||
| } | ||
|
|
||
| if baseOptions.ServiceName == "" { | ||
| return fmt.Errorf("--service is required") | ||
| } | ||
| return nil | ||
| }, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| ctx := cmd.Context() | ||
| if err := RunGenerateBasicReconciler(ctx, opt); err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
| opt.BindFlags(cmd) | ||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| func RunGenerateBasicReconciler(ctx context.Context, o *GenerateBasicReconcilerOptions) error { | ||
| crdOps := &generatetypes.GenerateCRDOptions{ | ||
| GenerateOptions: o.GenerateOptions, | ||
| OutputAPIDirectory: o.APIDirectory, | ||
| Resources: generatetypes.ResourceList{ | ||
| generatetypes.Resource{Kind: o.Kind, ProtoName: o.ProtoName}, | ||
| }, | ||
| } | ||
| if err := generatetypes.RunGenerateCRD(ctx, crdOps); err != nil { | ||
| return fmt.Errorf("generate types: %w", err) | ||
| } | ||
| mapperOps := &generatemapper.GenerateMapperOptions{ | ||
| GenerateOptions: o.GenerateOptions, | ||
| APIGoPackagePath: o.APIGoPackagePath, | ||
| APIDirectory: o.APIDirectory, | ||
| OutputMapperDirectory: o.OutputMapperDirectory, | ||
| } | ||
| if err := generatemapper.RunGenerateMapper(ctx, mapperOps); err != nil { | ||
| return fmt.Errorf("generate types: %w", err) | ||
| } | ||
| controllerOps := &generatecontroller.GenerateControllerOptions{ | ||
| GenerateOptions: o.GenerateOptions, | ||
| Kind: o.Kind, | ||
| ProtoName: o.ProtoName, | ||
| } | ||
| if err := generatecontroller.RunController(ctx, controllerOps); err != nil { | ||
| return fmt.Errorf("generate types: %w", err) | ||
| } | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters