Add check for empty socket.error args #1580

gustafsson · 2022-08-30T19:44:53Z

When doing a

gsutil cp myfile gs://mybucket/name

With a https_proxy that was limiting the number of concurrent sockets. I got a

socket.timeout: timed out

During handling of the above exception, another exception occurred:
...
socks.GeneralProxyError: Socket error: timed out

During handling of the above exception, another exception occurred:
...
~/Applications/google-cloud-sdk/platform/gsutil/gslib/gcs_json_media.py", line 587, in _conn_request
    err = getattr(e, 'args')[0]

It seems socket.error can have empty args. This PR adds a check.

gsutil_IndexError_tuple_index_out_of_range.txt

dilipped

Sorry for the late response here and thanks for the PR. Can you please add tests for the change? The test can go in the file tests/test_gcs_json_media.py.

dilipped · 2022-11-28T16:42:02Z

gslib/gcs_json_media.py

@@ -583,7 +583,7 @@ def _conn_request(self, conn, request_uri, method, body, headers):  # pylint: di
      raise
    except socket.error as e:
      err = 0
-      if hasattr(e, 'args'):
+      if hasattr(e, 'args') and getattr(e, 'args'):


You can replace the entire line with if getattr(e, 'args', None)

Add check for empty socket.error args

e2bae48

dilipped reviewed Nov 28, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add check for empty socket.error args #1580

Add check for empty socket.error args #1580

gustafsson commented Aug 30, 2022

dilipped left a comment

dilipped Nov 28, 2022

Add check for empty socket.error args #1580

Are you sure you want to change the base?

Add check for empty socket.error args #1580

Conversation

gustafsson commented Aug 30, 2022

dilipped left a comment

Choose a reason for hiding this comment

dilipped Nov 28, 2022

Choose a reason for hiding this comment