Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create batch using secret manager #4382

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

BigBlackWolf
Copy link
Contributor

Description

  • Created sample, which demonstrates how to use Secret Manage with Batch

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 16, 2024
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 16, 2024
@BigBlackWolf BigBlackWolf force-pushed the feat_batch_create_using_secret_manager branch from 3375d81 to b8dcb5c Compare September 17, 2024 08:26
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@BigBlackWolf BigBlackWolf added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 23, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 23, 2024
@telpirion telpirion self-assigned this Sep 23, 2024
@BigBlackWolf BigBlackWolf added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@BigBlackWolf BigBlackWolf force-pushed the feat_batch_create_using_secret_manager branch from 0da3298 to cb2de90 Compare September 24, 2024 12:14
@BigBlackWolf BigBlackWolf marked this pull request as ready for review September 24, 2024 12:44
@BigBlackWolf BigBlackWolf requested review from a team as code owners September 24, 2024 12:44
Copy link

snippet-bot bot commented Sep 24, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion added the api: secretmanager Issues related to the Secret Manager API. label Oct 10, 2024
@BigBlackWolf BigBlackWolf merged commit b67dff8 into main Oct 15, 2024
11 checks passed
@BigBlackWolf BigBlackWolf deleted the feat_batch_create_using_secret_manager branch October 15, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants