Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke enhancements] remove mash dependency #2547

Open
wants to merge 2 commits into
base: garnitin/add-gke-load-testing/upload-outputs-to-gsheet
Choose a base branch
from

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Oct 3, 2024

Description

Replace mash with monitoring-api everywhere

Purposes:

  • Consistent behavior across all machines
  • Monitoring API has faster runtime than mash.
  • Monitoring API is supported on GCE VM too.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle marked this pull request as ready for review October 3, 2024 07:40
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners October 3, 2024 07:40
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a998865 to ed56ec3 Compare October 3, 2024 17:47
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch 2 times, most recently from 3124adf to 3597a49 Compare October 3, 2024 19:23
Purposes.
* Consistent behavior across all machines
* Monitoring API has faster runtime than mash.
* Monitoring API is supported on GCE VM too.
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from d50d8d8 to e6a68ea Compare October 4, 2024 05:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 3597a49 to 0e196fe Compare October 4, 2024 05:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 0e196fe to ce3610e Compare October 4, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants