[testing-on-gke part independent 6.8] Add gsheet utilities #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
kislaykishore and
tritone
and removed request for
a team and
kislaykishore
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
4fd500c
to
87b8aac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2528 +/- ##
==========================================
- Coverage 78.87% 78.86% -0.02%
==========================================
Files 106 106
Lines 11690 11696 +6
==========================================
+ Hits 9221 9224 +3
- Misses 1990 1991 +1
- Partials 479 481 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
87b8aac
to
3a6f7ab
Compare
gargnitingoogle
changed the base branch from
master
to
garnitin/add-gke-load-testing/improvements-in-run-script
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
8e19d51
to
ecdee7c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
3a6f7ab
to
172032d
Compare
gargnitingoogle
changed the title
gargnitingoogle
commented
Sep 25, 2024
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
ecdee7c
to
52dd115
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
172032d
to
390fe46
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
52dd115
to
e875e2c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
2 times, most recently
from
b081112
to
3ed138f
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
bdf6b44
to
60aafb2
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
3ed138f
to
9d14972
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
60aafb2
to
0b97cc6
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
9d14972
to
4b551a4
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
2bf79fa
to
eb09af2
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
fc9e744
to
e308a05
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
eb09af2
to
78240a9
Compare
gargnitingoogle
commented
Sep 27, 2024
| Returns exit-code which would be non-zero for error. | ||
| """ | ||
| result = subprocess.run( | ||
| [word for word in command.split(" ") if (word and not str.isspace(word))], |
There was a problem hiding this comment.
Suggested change
| [word for word in command.split(" ") if (word and not str.isspace(word))], | |
| [word for word in command.split(" ") if word and word.strip()], |
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
e308a05
to
098cd78
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
78240a9
to
18c2f27
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
098cd78
to
4f58431
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
18c2f27
to
1a38752
Compare
gargnitingoogle
changed the title
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
4f58431
to
53858f6
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
1a38752
to
f524114
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
53858f6
to
4970493
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
f524114
to
e2ff044
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
4970493
to
b5fb15b
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
e2ff044
to
3af14bf
Compare
gargnitingoogle
commented
Oct 1, 2024
|
|
||
| class GsheetTest(unittest.TestCase): | ||
|
|
||
| # @classmethod |
There was a problem hiding this comment.
remove this commented out code
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
b5fb15b
to
d5053d3
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
3af14bf
to
3d46fbd
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
d5053d3
to
9329aae
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
3d46fbd
to
2dde58b
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
9329aae
to
b4db597
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
2dde58b
to
6b4bfa1
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
b4db597
to
d141ea7
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
2 times, most recently
from
b1f82bc
to
89a9ada
Compare
Utilities: 1. Append given tabular data to the given gsheet id and worksheet name. 2. Return url for a gsheet given its ID. 3. Adds unit tests for the above utilities.
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-gsheet-utility
branch
from
89a9ada
to
1fcf030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add utilities for gsheet
This is on top of #2498 and is followed in #2524 .
Link to the issue in case of a bug fix.
NA
Testing details