Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing-on-gke part 6.6] Enforce one pod per node #2497

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[testing-on-gke part 6.6] Enforce one pod per node #2497

merged 2 commits into from
Oct 3, 2024

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Sep 17, 2024 •
edited
Loading

Description

This is on top of #2496 and is followed up in #2498 .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle mentioned this pull request Sep 17, 2024
Merged
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 6.5] nforce one pod per node [testing-on-gke part 6.5] Enforce one pod per node Sep 17, 2024
@gargnitingoogle gargnitingoogle changed the base branch from master to garnitin/add-gke-load-testing/move-iam-config-to-backend September 17, 2024 06:17
@gargnitingoogle gargnitingoogle mentioned this pull request Sep 17, 2024
Open
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 98794f7 to ddcef98 Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from b77d5ef to bf0661a Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from ddcef98 to d0e876b Compare September 17, 2024 10:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from bf0661a to c49f080 Compare September 17, 2024 10:20
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from d0e876b to d7efbe5 Compare September 17, 2024 10:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from c49f080 to ac9c164 Compare September 17, 2024 10:30
@gargnitingoogle gargnitingoogle marked this pull request as ready for review September 17, 2024 10:37
@gargnitingoogle gargnitingoogle requested review from vadlakondaswetha and removed request for a team September 17, 2024 10:37
@gargnitingoogle gargnitingoogle mentioned this pull request Sep 17, 2024
Closed
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from d7efbe5 to 809174f Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from ac9c164 to 4d3d3fb Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 809174f to abbefaf Compare September 18, 2024 06:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 4d3d3fb to d77db67 Compare September 18, 2024 06:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from abbefaf to ebf4a2a Compare September 18, 2024 08:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from d77db67 to 5825918 Compare September 18, 2024 08:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from ebf4a2a to aa43846 Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 5825918 to ee6d69c Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from aa43846 to 0b48a2d Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from ee6d69c to c93fde8 Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 6.5] Enforce one pod per node [testing-on-gke part 6.6] Enforce one pod per node Sep 18, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 0b48a2d to 35420e2 Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 6a51836 to f9024c4 Compare September 27, 2024 06:12
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 1c6ef8b to ab210db Compare September 27, 2024 07:52
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from f9024c4 to fb265f6 Compare September 27, 2024 07:52
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from ab210db to fbbfcbf Compare September 27, 2024 09:31
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from fb265f6 to a7e792c Compare September 27, 2024 09:31
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from fbbfcbf to 40ae805 Compare September 27, 2024 09:44
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from a7e792c to 5ffa924 Compare September 27, 2024 09:44
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 40ae805 to ff95544 Compare September 27, 2024 12:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 5ffa924 to 80ba061 Compare September 27, 2024 12:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from ff95544 to 6c1d84e Compare September 27, 2024 13:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 80ba061 to 8853939 Compare September 27, 2024 13:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 6c1d84e to edff1de Compare September 27, 2024 14:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 8853939 to 791a829 Compare September 27, 2024 14:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from edff1de to cf2deda Compare September 30, 2024 04:42
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 791a829 to 7a4b4ce Compare September 30, 2024 04:42
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from cf2deda to 1e5f648 Compare September 30, 2024 05:05
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 7a4b4ce to 7b4c4a4 Compare September 30, 2024 05:05
kislaykishore
kislaykishore previously approved these changes Oct 1, 2024
View reviewed changes
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 1e5f648 to 91b686e Compare October 2, 2024 23:35
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch 2 times, most recently from fcb0e5f to d4a44f3 Compare October 3, 2024 00:13
@gargnitingoogle
Enforce one pod per node
a8d55d1 
It figures out he resource capacities of
the actual machine-type of the node,
and uses it in the pod-config to
set resources.{requests|limits}
to enforce each pod/workload to run
in its own dedicated node.
@gargnitingoogle
add utils unit tests for resource limits
db1581a
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from d4a44f3 to db1581a Compare October 3, 2024 04:07
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/move-iam-config-to-backend to master October 3, 2024 04:08
@gargnitingoogle gargnitingoogle dismissed kislaykishore’s stale review October 3, 2024 04:08

The base branch was changed.

@kislaykishore kislaykishore requested a review from a team October 3, 2024 04:09
@gargnitingoogle gargnitingoogle merged commit d6bb23e into master Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kislaykishore kislaykishore kislaykishore approved these changes

@Tulsishah Tulsishah Awaiting requested review from Tulsishah Tulsishah is a code owner

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha vadlakondaswetha is a code owner automatically assigned from GoogleCloudPlatform/gcsfuse-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gargnitingoogle @kislaykishore