Add more tests on the data of translated CloudEvents. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests check what is in the `data` field of the CloudEvents that we translate from legacy events. For now they are not all that useful, because that field is basically just a copy of the JSON payload of the legacy event. But we do rearrange things slightly for PubSub events, and we are likely to do so for Firebase events too in the future. Furthermore, if we eventually have a library of classes representing the various event payloads, then we can use that library instead of working with the JSON directly. That is what google-cloudevents-dotnet does, for example.
|
Will look on Monday |
jskeet
approved these changes
Sep 15, 2020
| } | ||
|
|
||
| @Test | ||
| public void firestoreComplexData() throws IOException { |
There was a problem hiding this comment.
This test in .NET was mostly because we have helpers to make Firestore easier to work with. You probably don't need this test here.
There was a problem hiding this comment.
Right, the comment on lines 93–98 says we're not testing much here, but I think it is useful to show that we can successfully dissect a complex value, even if it is currently quite tedious and manual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests check what is in the
datafield of the CloudEvents that wetranslate from legacy events. For now they are not all that useful, because that
field is basically just a copy of the JSON payload of the legacy event. But we
do rearrange things slightly for PubSub events, and we are likely to do so for
Firebase events too in the future. Furthermore, if we eventually have a library
of classes representing the various event payloads, then we can use that library
instead of working with the JSON directly. That is what
google-cloudevents-dotnet does, for example.